From dev-return-89270-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Jun 12 14:48:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53634180608 for ; Tue, 12 Jun 2018 14:48:51 +0200 (CEST) Received: (qmail 29695 invoked by uid 500); 12 Jun 2018 12:48:50 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 29684 invoked by uid 99); 12 Jun 2018 12:48:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jun 2018 12:48:50 +0000 From: GitBox To: dev@sling.apache.org Subject: =?utf-8?q?=5BGitHub=5D_rombert_commented_on_issue_=234=3A_SLING-7630=3A_C?= =?utf-8?q?reated_the_constructors_so_that_non-OSGi_containers_can_?= =?utf-8?b?4oCm?= Message-ID: <152880772940.12680.2226120454133091007.gitbox@gitbox.apache.org> Date: Tue, 12 Jun 2018 12:48:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rombert commented on issue #4: SLING-7630: Created the constructors so that non-OSGi containers can … URL: https://github.com/apache/sling-ide-tooling/pull/4#issuecomment-396577222 Looks good to me, thanks! I would only suggest that you add a comment to the no-arg constructors, something similar to "Used by declarative services implementation" to make it clear why we're keeping them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services