sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] andreituicu commented on issue #2: SLING-7752 - Deserializing and serializing a feature model file suffles the configurations
Date Fri, 22 Jun 2018 14:37:29 GMT
andreituicu commented on issue #2: SLING-7752 - Deserializing and serializing a feature model
file suffles the configurations
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/2#issuecomment-399464644
 
 
   @rombert @bosschaert Thank you for the review! I updated the PR according to your review.
I changed the API to use `Map` and `LinkedHashMap` and updated the necessary code. One thing
to note is that now the baseline plugin fails the build as it wants a version bump to `1.0.0`
and this would take us out of the beta and into the backwards compatibility zone. Is there
anything I can do to make it stop or will it have to be skipped at the release time? I'll
see if this change has any implications on https://github.com/apache/sling-org-apache-sling-feature-io.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message