From dev-return-88910-archive-asf-public=cust-asf.ponee.io@sling.apache.org Mon May 28 14:41:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9C511180676 for ; Mon, 28 May 2018 14:41:05 +0200 (CEST) Received: (qmail 9543 invoked by uid 500); 28 May 2018 12:41:04 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 9532 invoked by uid 99); 28 May 2018 12:41:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 May 2018 12:41:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 326261A2599 for ; Mon, 28 May 2018 12:41:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id u0z01onLMGMq for ; Mon, 28 May 2018 12:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1CE555FAC9 for ; Mon, 28 May 2018 12:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 242E5E0F39 for ; Mon, 28 May 2018 12:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 78288210A1 for ; Mon, 28 May 2018 12:41:00 +0000 (UTC) Date: Mon, 28 May 2018 12:41:00 +0000 (UTC) From: "Konrad Windszus (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492625#comment-16492625 ] Konrad Windszus edited comment on SLING-7624 at 5/28/18 12:40 PM: ------------------------------------------------------------------ [~jsedding] Let me quickly outline the reasons: * {{@SlingServletPaths}} and {{SlingServletResourceTypes}} is separated because for the latter a lot of additional restrictions may be maintained (selectors, extensions, methods), while for the former this is not supported. Having both types supported with the same annotation would lead to a lot of elements which would only make sense for one type * {{@SlingServletPrefix}}, basically [~cziegeler] asked for a separation in https://issues.apache.org/jira/browse/SLING-7624?focusedCommentId=16473614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16473614. The main reason is that prefix is rarely used and actually the same property is used for both servlet types (registered by type and by path). To make that clearer a common dedicated annotation is provided for that. * {{@SlingServletName}} is a dedicated annotation for very similar reasons as for {{SlingServletPrefix}}. In addition this property is not really bound to registering servlets at all. * {{@SlingServletFilter}} is actually just a single annotation. Do you agree with those reasons? was (Author: kwin): [~jsedding] Let me quickly outline the reasons: * {{@SlingServletPaths}} and {{SlingServletResourceTypes}} is separated because for the latter a lot of additional restrictions may be maintained (selectors, extensions, methods), while for the former this is not supported. Having both types supported with the same annotation would lead to a lot of elements which would only make sense for one type * {{@SlingServletPrefix}}, basically [~cziegeler] asked for a separation in https://issues.apache.org/jira/browse/SLING-7624?focusedCommentId=16473614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16473614. The main reason is that prefix is rarely used and actually the same property is used for both servlet types (registered by type and by path). To make that clearer a common dedicated annotation is provided for that. * {{@SlingServletName}} is a dedicated annotation for very similar reasons as for {{SlingServletPrefix}}. In addition this property is not really bound to registering servlets at all. * {{@SlingServletFilter}} is actually just a single annotation. > Add OSGi7 component property annotations for Servlet and Filter > --------------------------------------------------------------- > > Key: SLING-7624 > URL: https://issues.apache.org/jira/browse/SLING-7624 > Project: Sling > Issue Type: New Feature > Components: Servlets > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > > Previously there were annotations hosted at Felix for Sling Servlets/Filters as custom Felix SCR annotations (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling). With OSGi R7 and DS 1.4 component property annotations are specified. Sling should provide those annotations in a dedicated new artifact. Compare also with FELIX-5396. > Those are supported in the upcoming bnd 4.0 (https://github.com/bndtools/bnd/issues/2163). -- This message was sent by Atlassian JIRA (v7.6.3#76005)