From dev-return-89043-archive-asf-public=cust-asf.ponee.io@sling.apache.org Thu May 31 10:39:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4581C180632 for ; Thu, 31 May 2018 10:39:56 +0200 (CEST) Received: (qmail 48054 invoked by uid 500); 31 May 2018 08:39:55 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 48042 invoked by uid 99); 31 May 2018 08:39:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 May 2018 08:39:55 +0000 From: GitBox To: dev@sling.apache.org Subject: [GitHub] JEBailey commented on a change in pull request #4: Provide name hints for SDI configuration entries Message-ID: <152775599445.10662.14460615728669963329.gitbox@gitbox.apache.org> Date: Thu, 31 May 2018 08:39:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit JEBailey commented on a change in pull request #4: Provide name hints for SDI configuration entries URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#discussion_r192026795 ########## File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java ########## @@ -97,6 +98,11 @@ static final String PROPERTY_REWRITE_PATH = "include-filter.config.rewrite"; + static final String NAME_HINT_PROPERTY_NAME = "webconsole.configurationFactory.nameHint"; Review comment: Per http://felix.apache.org/documentation/subprojects/apache-felix-web-console.html the property for nameHint should not be private. However I’m not sure if that is still applicable with the newer annotations ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services