sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7660) LogManager configuration "Number of Log Files" limited to 20
Date Mon, 14 May 2018 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473899#comment-16473899
] 

Chetan Mehrotra commented on SLING-7660:
----------------------------------------

+1 to increase the size. Not sure on setting it to max. From [LOGBACK-266|https://jira.qos.ch/browse/LOGBACK-266]
it appears that limit has some reasoning. 

bq. It seems the limit is there, since for each roll, where maxIndex=N, there are N file renames,
and this doesn't scale well up to 100 renames. (Well actually it depends on the filesystem)

>From the referred issue it appears that recommendation is to use [SizeAndTimeBasedFNATP|https://logback.qos.ch/manual/appenders.html#SizeAndTimeBasedFNATP]

> LogManager configuration "Number of Log Files" limited to 20
> ------------------------------------------------------------
>
>                 Key: SLING-7660
>                 URL: https://issues.apache.org/jira/browse/SLING-7660
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Log 5.1.6
>            Reporter: Julian Sedding
>            Assignee: Julian Sedding
>            Priority: Minor
>             Fix For: Commons Log 5.1.8
>
>
> The "Number of Log Files" configuration property for size-based log rotation is capped
at 20 (or 21 including the current log file. This limitation comes from [logback's {{FixedWindowRollingPolicy}}|https://github.com/qos-ch/logback/blob/39c7ab9510c4f48ef3fcbef248aac380d3b58235/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java#L47],
but can be overridden in a subclass. I propose to override the {{FixedWindowRollingPolicy#getMaxWindowSize}}
to return {{Integer.MAX_VALUE}}.
> cc [~chetanm]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message