sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bertrand Delacretaz (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SLING-7637) PropertyRenderingTest fails
Date Thu, 03 May 2018 12:09:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bertrand Delacretaz resolved SLING-7637.
----------------------------------------
    Resolution: Fixed
      Assignee: Bertrand Delacretaz

I have fixed the test with this commit:

https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/2001e979f756eba37aa71e6c6db850987e8e33ed

But I'm not sure what caused it to fail. The root cause is that HttpClient gets a redirect
if the URL ends with /multiText without a trailing / and the GET request that follows the
redirect doesn't include credentials (see requests dump below).

The change might be that Sling previously didn't send a redirect, or that it didn't require
credentials before. Or maybe that the httpclient version changed and behaves differently.

Requests/responses:

{code}
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText HTTP
  /1.1..Authorization: Basic YWRtaW46YWRtaW4=..User-Agent: Jakarta Commons-Htt
  pClient/3.1..Host: localhost:8080....                                       
##
T 127.0.0.1:8080 -> 127.0.0.1:57426 [AP]
  HTTP/1.1 302 Found..Date: Thu, 03 May 2018 11:54:40 GMT..X-Content-Type-Opti
  ons: nosniff..X-Frame-Options: SAMEORIGIN..FILTER_COUNTER_SLING: 1..FILTER_C
  OUNTER_NOPROP: 1..Location: http://localhost:8080/PropertyRenderingTest/1525
  348448317/this_is_a_test_15253/multiText/..Content-Length: 0....            
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText/ HTT
  P/1.1..User-Agent: Jakarta Commons-HttpClient/3.1..Host: localhost:8080.... 
##
{code}

The second GET does not include the {{Authorization}} header.

> PropertyRenderingTest fails
> ---------------------------
>
>                 Key: SLING-7637
>                 URL: https://issues.apache.org/jira/browse/SLING-7637
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Robert Munteanu
>            Assignee: Bertrand Delacretaz
>            Priority: Major
>              Labels: sling-IT
>
> org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
fails with {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
expected:<403> but was:<404>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message