sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bertrand Delacretaz (JIRA)" <>
Subject [jira] [Resolved] (SLING-7637) PropertyRenderingTest fails
Date Thu, 03 May 2018 12:09:00 GMT


Bertrand Delacretaz resolved SLING-7637.
    Resolution: Fixed
      Assignee: Bertrand Delacretaz

I have fixed the test with this commit:

But I'm not sure what caused it to fail. The root cause is that HttpClient gets a redirect
if the URL ends with /multiText without a trailing / and the GET request that follows the
redirect doesn't include credentials (see requests dump below).

The change might be that Sling previously didn't send a redirect, or that it didn't require
credentials before. Or maybe that the httpclient version changed and behaves differently.


T -> [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText HTTP
  /1.1..Authorization: Basic YWRtaW46YWRtaW4=..User-Agent: Jakarta Commons-Htt
  pClient/3.1..Host: localhost:8080....                                       
T -> [AP]
  HTTP/1.1 302 Found..Date: Thu, 03 May 2018 11:54:40 GMT..X-Content-Type-Opti
  ons: nosniff..X-Frame-Options: SAMEORIGIN..FILTER_COUNTER_SLING: 1..FILTER_C
  OUNTER_NOPROP: 1..Location: http://localhost:8080/PropertyRenderingTest/1525
  348448317/this_is_a_test_15253/multiText/..Content-Length: 0....            
T -> [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText/ HTT
  P/1.1..User-Agent: Jakarta Commons-HttpClient/3.1..Host: localhost:8080.... 

The second GET does not include the {{Authorization}} header.

> PropertyRenderingTest fails
> ---------------------------
>                 Key: SLING-7637
>                 URL:
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Robert Munteanu
>            Assignee: Bertrand Delacretaz
>            Priority: Major
>              Labels: sling-IT
fails with {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
expected:<403> but was:<404>}}

This message was sent by Atlassian JIRA

View raw message