sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter
Date Mon, 28 May 2018 12:41:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492625#comment-16492625
] 

Konrad Windszus commented on SLING-7624:
----------------------------------------

[~jsedding] Let me quickly outline the reasons:
* {{@SlingServletPaths}} and {{SlingServletResourceTypes}} is separated because for the latter
a lot of additional restrictions may be maintained (selectors, extensions, methods), while
for the former this is not supported. Having both types supported with the same annotation
would lead to a lot of elements which would only make sense for one type
* {{@SlingServletPrefix}}, basically [~cziegeler] asked for a separation in https://issues.apache.org/jira/browse/SLING-7624?focusedCommentId=16473614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16473614.
The main reason is that prefix is rarely used and actually the same property is used for both
servlet types (registered by type and by path). To make that clearer a common dedicated annotation
is provided for that.
* {{@SlingServletName}} is a dedicated annotation for very similar reasons as for {{SlingServletPrefix}}.
In addition this property is not really bound to registering servlets at all.
* {{@SlingServletFilter}} is actually just a single annotation.

> Add OSGi7 component property annotations for Servlet and Filter
> ---------------------------------------------------------------
>
>                 Key: SLING-7624
>                 URL: https://issues.apache.org/jira/browse/SLING-7624
>             Project: Sling
>          Issue Type: New Feature
>          Components: Servlets
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> Previously there were annotations hosted at Felix for Sling Servlets/Filters as custom
Felix SCR annotations (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling).
With OSGi R7 and DS 1.4 component property annotations are specified. Sling should provide
those annotations in a dedicated new artifact. Compare also with FELIX-5396.
> Those are supported in the upcoming bnd 4.0 (https://github.com/bndtools/bnd/issues/2163).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message