sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] JEBailey commented on a change in pull request #4: Provide name hints for SDI configuration entries
Date Thu, 31 May 2018 08:39:54 GMT
JEBailey commented on a change in pull request #4: Provide name hints for SDI configuration
entries
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#discussion_r192026795
 
 

 ##########
 File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java
 ##########
 @@ -97,6 +98,11 @@
 
   static final String PROPERTY_REWRITE_PATH = "include-filter.config.rewrite";
 
+  static final String NAME_HINT_PROPERTY_NAME = "webconsole.configurationFactory.nameHint";
 
 Review comment:
   Per http://felix.apache.org/documentation/subprojects/apache-felix-web-console.html the
property for nameHint should not be private. However I’m not sure if that is still applicable
with the newer annotations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message