From dev-return-87872-archive-asf-public=cust-asf.ponee.io@sling.apache.org Mon Apr 16 20:23:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4796118077A for ; Mon, 16 Apr 2018 20:23:04 +0200 (CEST) Received: (qmail 33345 invoked by uid 500); 16 Apr 2018 18:23:03 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 33309 invoked by uid 99); 16 Apr 2018 18:23:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 18:23:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DB852C08AE for ; Mon, 16 Apr 2018 18:23:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Hw0heeigp1VO for ; Mon, 16 Apr 2018 18:23:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 963185FB94 for ; Mon, 16 Apr 2018 18:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9E69AE0BE9 for ; Mon, 16 Apr 2018 18:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B9EB21208 for ; Mon, 16 Apr 2018 18:23:00 +0000 (UTC) Date: Mon, 16 Apr 2018 18:23:00 +0000 (UTC) From: "Justin Edelson (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7584) Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7584?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1643= 9818#comment-16439818 ]=20 Justin Edelson commented on SLING-7584: --------------------------------------- pull request:=C2=A0https://github.com/apache/sling-org-apache-sling-models-= impl/pull/5/files > Only the last DisposalCallbackRegistry is disposed when multiple models a= re adapted in the same request > -------------------------------------------------------------------------= ------------------------------ > > Key: SLING-7584 > URL: https://issues.apache.org/jira/browse/SLING-7584 > Project: Sling > Issue Type: Bug > Components: Extensions > Affects Versions: Sling Models Impl 1.4.6, Sling Models Impl 1.4.8 > Reporter: Justin Edelson > Priority: Major > Fix For: Sling Models Impl 1.4.10 > > Time Spent: 10m > Remaining Estimate: 0h > > The implementation of=C2=A0SLING-5668 naively assumes that only a single = disposal callback registry will be used per request. This is plainly not th= e case and unfortunately results in only the last callback for a given requ= est to be invoked. -- This message was sent by Atlassian JIRA (v7.6.3#76005)