From dev-return-87571-archive-asf-public=cust-asf.ponee.io@sling.apache.org Tue Mar 20 16:20:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5744718064A for ; Tue, 20 Mar 2018 16:20:03 +0100 (CET) Received: (qmail 67526 invoked by uid 500); 20 Mar 2018 15:20:02 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 67460 invoked by uid 99); 20 Mar 2018 15:20:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Mar 2018 15:20:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C6638180457 for ; Tue, 20 Mar 2018 15:20:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id C-kwrp69lr5u for ; Tue, 20 Mar 2018 15:20:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BD7EF5F178 for ; Tue, 20 Mar 2018 15:20:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A6F9E02D4 for ; Tue, 20 Mar 2018 15:20:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 12526214BD for ; Tue, 20 Mar 2018 15:20:00 +0000 (UTC) Date: Tue, 20 Mar 2018 15:20:00 +0000 (UTC) From: =?utf-8?Q?J=C3=B6rg_Hoh_=28JIRA=29?= To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (SLING-7552) SlingPostServlet error handling still insufficient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 J=C3=B6rg Hoh created SLING-7552: ------------------------------- Summary: SlingPostServlet error handling still insufficient Key: SLING-7552 URL: https://issues.apache.org/jira/browse/SLING-7552 Project: Sling Issue Type: Improvement Reporter: J=C3=B6rg Hoh At the moment the default errorhandling of Sling [1] cannot be used for err= ors caused and handled by the SlingPostServlet itself. It will always retur= n its own custom output without the chance of customizing it. Although Anto= nio and Justing worked in SLING-2156 to improve this situation, it still re= quires extra work (implementing a PostResponseWithErrorHandling). It would = be better if the output could be customized by the "standard error handling= ". =C2=A0 How to reproduce: * create an error handling script in /apps/sling/servlet/errorhandler/defa= ult.jsp which creates some random output. * Validate this script config by doing a request which causes some excepti= on (do not use the SlingPostServlet here) * Do a POST to the Sling instance which results in an exception (e.g. due = to insufficient permissions. * The output of the second call is completely determined by the SlingPostS= ervlet, the default error handling does not kick in. Proposed solution: * The SlingPostServlet should not swallow the exception and handle it by it= self, but rather re-throw it, so the standard error handling is triggered. =C2=A0 [1] http://sling.apache.org/documentation/the-sling-engine/errorhandling.ht= ml -- This message was sent by Atlassian JIRA (v7.6.3#76005)