sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: [VOTE] Release Apache Sling API 2.17.0
Date Tue, 13 Mar 2018 20:09:59 GMT
Hmm interesting, I can't remember to change it, but apparently it got
changed by my commit. That's a mistake.

I guess the best would be to revert that change and do another release

WDYT?

Carsten


Oliver Lietz wrote
> On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote:
>> Hi Oli
>>
>> I think it's ok, because ResourceResolver#getSearchPath() also returns
>> String[]. So I think for consistency's sake we should leave it as-is.
>> While I agree with you in principle, there are other examples where
>> the singular term is used to refer to a list of paths, e.g. the java
>> classpath.
> 
> ACK, makes sense to be consistent.
> 
> Why was package version for o.a.s.request increased?
> 
> Thanks, Julian!
> 
> O.
> 
>> Regards
>> Julian
>>
>> On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietz <apache@oliverlietz.de> wrote:
>>> On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote:
>>>> Hi,
>>>
>>> Hi,
>>>
>>>> We solved 3 issues in this release:
>>>>
>>>> https://issues.apache.org/jira/projects/SLING/versions/12342301
>>>
>>> SLING-7537: The method name should be getSearchPaths() instead of
>>> getSearchPath() as it returns a list of strings (paths), no?
>>>
>>> Regards,
>>> O.
>>>
>>> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/
>>> java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Mime
View raw message