sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7519) Add webconsole ds module to SlingOptions
Date Tue, 27 Feb 2018 14:21:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378637#comment-16378637
] 

ASF GitHub Bot commented on SLING-7519:
---------------------------------------

rombert closed pull request #1: SLING-7519 Add webconsole ds module to get better insight
into DS 
URL: https://github.com/apache/sling-org-apache-sling-testing-paxexam/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 146e1ab..41bbc14 100644
--- a/pom.xml
+++ b/pom.xml
@@ -152,6 +152,11 @@
       <version>${org.ops4j.pax.exam.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
 </project>
diff --git a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
index ae5d333..8ce5810 100644
--- a/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
+++ b/src/main/java/org/apache/sling/testing/paxexam/SlingOptions.java
@@ -81,7 +81,9 @@ public static Option scr() {
 
     public static Option webconsole() {
         return composite(
+            scr(),
             mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole").version(versionResolver),
+            mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.webconsole.plugins.ds").version(versionResolver),
             mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.inventory").version(versionResolver),
             mavenBundle().groupId("commons-fileupload").artifactId("commons-fileupload").version(versionResolver),
             mavenBundle().groupId("commons-io").artifactId("commons-io").version(versionResolver),


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add webconsole ds module to SlingOptions
> ----------------------------------------
>
>                 Key: SLING-7519
>                 URL: https://issues.apache.org/jira/browse/SLING-7519
>             Project: Sling
>          Issue Type: Improvement
>    Affects Versions: Sling Pax Exam Utilities 1.0.4
>            Reporter: Christian Schneider
>            Priority: Major
>             Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> Sling uses DS all over the place. We should add the ds module for the webconsole to have
more insight into the DS components in tests.
> I will supply a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message