From dev-return-86249-archive-asf-public=cust-asf.ponee.io@sling.apache.org Wed Jan 31 15:33:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EF077180662 for ; Wed, 31 Jan 2018 15:33:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DE571160C35; Wed, 31 Jan 2018 14:33:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31D67160C25 for ; Wed, 31 Jan 2018 15:33:08 +0100 (CET) Received: (qmail 83171 invoked by uid 500); 31 Jan 2018 14:33:07 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 83160 invoked by uid 99); 31 Jan 2018 14:33:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 14:33:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 974FA195182 for ; Wed, 31 Jan 2018 14:33:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6QCj2Owf_A-d for ; Wed, 31 Jan 2018 14:33:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 810B060D3D for ; Wed, 31 Jan 2018 14:33:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DDEE4E0230 for ; Wed, 31 Jan 2018 14:33:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0035F24116 for ; Wed, 31 Jan 2018 14:33:01 +0000 (UTC) Date: Wed, 31 Jan 2018 14:33:00 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7456) FlushCache in SlingServletResolver can throw an NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SLING-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346913#comment-16346913 ] Carsten Ziegeler commented on SLING-7456: ----------------------------------------- This is interesting, the resolver is only registered as an event receiver if the cache is not null. However if the jmx bean is invoked, there should be a null check nevertheless. > FlushCache in SlingServletResolver can throw an NPE > --------------------------------------------------- > > Key: SLING-7456 > URL: https://issues.apache.org/jira/browse/SLING-7456 > Project: Sling > Issue Type: Bug > Components: Servlets > Affects Versions: Servlets Resolver 2.4.22 > Reporter: Karl Pauls > Priority: Minor > Fix For: Servlets Resolver 2.4.24 > > > Given that we check for the this.cache being null everytime we reference the cache we should probably do the same in flushCache. I can't reproduce it but the NPE looked like this: > {noformat} > java.lang.NullPointerException: null > at org.apache.sling.servlets.resolver.internal.SlingServletResolver.flushCache(SlingServletResolver.java:1122) [org.apache.sling.servlets.resolver:2.4.22] > at org.apache.sling.servlets.resolver.internal.SlingServletResolver.onChange(SlingServletResolver.java:1464) [org.apache.sling.servlets.resolver:2.4.22] > at org.apache.sling.resourceresolver.impl.observation.BasicObservationReporter.reportChanges(BasicObservationReporter.java:211) [org.apache.sling.resourceresolver:1.5.34] > at org.apache.sling.jcr.resource.internal.JcrResourceListener.onEvent(JcrResourceListener.java:155) [org.apache.sling.jcr.resource:3.0.8] > at org.apache.jackrabbit.commons.observation.ListenerTracker$1.onEvent(ListenerTracker.java:190) [org.apache.jackrabbit.jackrabbit-jcr-commons:2.16.0] > at org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor.contentChanged(ChangeProcessor.java:508) [org.apache.jackrabbit.oak-jcr:1.8.1] > at org.apache.jackrabbit.oak.plugins.observation.FilteringDispatcher.contentChanged(FilteringDispatcher.java:53) [org.apache.jackrabbit.oak-core:1.8.1] > at org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:128) [org.apache.jackrabbit.oak-store-spi:1.8.1] > at org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:122) [org.apache.jackrabbit.oak-store-spi:1.8.1] > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) > at java.base/java.lang.Thread.run(Thread.java:844) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)