sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SLING-7365) Some JSP tests fail under Java 10 - parameterized types are only available if source level is 1.5 or greater
Date Mon, 08 Jan 2018 16:13:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316522#comment-16316522
] 

Konrad Windszus edited comment on SLING-7365 at 1/8/18 4:12 PM:
----------------------------------------------------------------

ECJ now supports proper release versions (i.e. the same as javac): http://git.eclipse.org/c/gerrit/jdt/eclipse.jdt.core.git/commit/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java?id=4f45a6731c312108c51502feb3fbac24aa3a8fd3
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=480992) but only up to version 9. I think it
is reasonable to fall back to the closest known version in case you are running with an unknown
java version instead of falling back to Java 5.


was (Author: kwin):
ECJ now supports proper releases: http://git.eclipse.org/c/gerrit/jdt/eclipse.jdt.core.git/commit/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java?id=4f45a6731c312108c51502feb3fbac24aa3a8fd3
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=480992) but only up to version 9. I think it
is reasonable to fall back to the closest known version in case you are running with an unknown
java version instead of falling back to Java 5.

> Some JSP tests fail under Java 10 -  parameterized types are only available if source
level is 1.5 or greater
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-7365
>                 URL: https://issues.apache.org/jira/browse/SLING-7365
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>    Affects Versions: Commons Compiler 2.3.4
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>
> {noformat}An error occurred at line: 792 in the generated java file
> Syntax error, parameterized types are only available if source level is 1.5 or greater
> 	at org.apache.sling.scripting.jsp.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:92)
> 	at org.apache.sling.scripting.jsp.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:330)
> 	at org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:136)
> 	at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:304)
> 	at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:282)
> 	at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:269)
> 	at org.apache.sling.scripting.jsp.jasper.JspCompilationContext.compile(JspCompilationContext.java:501)
> 	at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.prepareServlet(JspServletWrapper.java:427)
> 	at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:486)
> 	at org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> 	at org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:342)
> 	at org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:97)
> 	at org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:603)
> 	at org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> 	at org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> 	at org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> 	at org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> 	at org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> 	at org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> 	at org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> 	at org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:68)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:73)
> 	at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
> 	at org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:68)
> 	at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
> 	at org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:68)
> 	at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:138)
> 	at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:68)
> 	at org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
> 	at org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
> 	at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:85)
> 	at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:79)
> 	at org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
> 	at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> 	at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> 	at org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> 	at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> 	at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> 	at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:138)
> 	at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> 	at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> 	at org.apache.sling.engine.impl.log.RequestLoggerFilter.doFilter(RequestLoggerFilter.java:72)
> 	at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> 	at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:74)
> 	at org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:128)
> 	at org.apache.felix.http.base.internal.dispatch.DispatcherServlet.service(DispatcherServlet.java:49)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> 	at org.apache.felix.http.bridge.internal.BridgeActivator$1.service(BridgeActivator.java:83)
> 	at org.apache.felix.http.proxy.ProxyServlet.service(ProxyServlet.java:123)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> 	at org.apache.sling.launchpad.base.webapp.SlingServletDelegate.service(SlingServletDelegate.java:286)
> 	at org.apache.sling.launchpad.webapp.SlingServlet.service(SlingServlet.java:175)
> 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:837)
> 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> 	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
> 	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
> 	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
> 	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:511)
> 	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> 	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> 	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:213)
> 	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
> 	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
> 	at org.eclipse.jetty.server.Server.handle(Server.java:523)
> 	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
> 	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
> 	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:273)
> 	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95)
> 	at org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
> 	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
> 	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
> 	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
> 	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
> 	at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
> 	at java.base/java.lang.Thread.run(Thread.java:844){noformat}
> This is the same issue as SLING-7105 just this time for Java 10 (latest EA). We should
try to come up with a more "persistent" fix as the Java release cycle will be shorter in the
future and Java 10 will be released in March 2018 (http://openjdk.java.net/projects/jdk/10/).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message