sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SLING-7294) SlingInstanceRule should also support instances provisioned via slingstart-maven-plugin
Date Sat, 09 Dec 2017 10:58:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konrad Windszus updated SLING-7294:
-----------------------------------
    Description: 
Currently the {{SlingInstanceRule}} uses the {{SlingTestBase}} from {{o.a.s.testing.serversetup}}
to connect to an existing instance (https://github.com/apache/sling-org-apache-sling-testing-rules/blob/master/src/main/java/org/apache/sling/testing/junit/rules/SlingInstanceRule.java#L44).
IMHO right now it is more intuitive to leverage the {{slingstart-maven-plugin}} with a given
model.txt to create a new launchpad and also start that, instead of using {{o.a.s.testing.serversetup}}.
 
For an example leveraging the bootstrapping and starting with {{slingstart-maven-plugin}}
look at https://github.com/apache/sling-org-apache-sling-models-validation-impl/blob/master/pom.xml#L78.

Currently, any IT annotated with {{@SlingInstanceRule}} fails for this project with an error
like
{code}
No files found in jar folder specified by jar.executor.jar.folder property: <somepath>
	at org.apache.sling.testing.serversetup.jarexec.JarExecutor.<init>(JarExecutor.java:111)
	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:89)
	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:70)
	at org.apache.sling.testing.junit.rules.SlingInstanceRule.<clinit>(SlingInstanceRule.java:44)
	....
{code}

Either this annotation should also support instances started via the slingstart-maven-plugin
or there should be a dedicated annotation for that.

  was:
Currently the {{SlinginstanceRule}} uses the {{SlingTestBase}} from {{o.a.s.testing.serversetup}}
to connect to an existing instance. IMHO right now it is more intuitive to leverage the {{slingstart-maven-plugin}}
with a given model.txt to create a new launchpad and also execute it.
 
For an example with that approach look at https://github.com/apache/sling-org-apache-sling-models-validation-impl/blob/master/pom.xml#L78.

Currently any IT annotated with {{@SlingInstanceRule}} fails for this project with an error
like
{code}
No files found in jar folder specified by jar.executor.jar.folder property: <somepath>
	at org.apache.sling.testing.serversetup.jarexec.JarExecutor.<init>(JarExecutor.java:111)
	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:89)
	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:70)
	at org.apache.sling.testing.junit.rules.SlingInstanceRule.<clinit>(SlingInstanceRule.java:44)
	....
{code}

Either this annotation should also support instances started via the slingstart-maven-plugin
or there should be a dedicated annotation for that.


> SlingInstanceRule should also support instances provisioned via slingstart-maven-plugin
> ---------------------------------------------------------------------------------------
>
>                 Key: SLING-7294
>                 URL: https://issues.apache.org/jira/browse/SLING-7294
>             Project: Sling
>          Issue Type: Bug
>          Components: Apache Sling Testing Rules
>    Affects Versions: Apache Sling Testing Rules 1.0.6
>            Reporter: Konrad Windszus
>
> Currently the {{SlingInstanceRule}} uses the {{SlingTestBase}} from {{o.a.s.testing.serversetup}}
to connect to an existing instance (https://github.com/apache/sling-org-apache-sling-testing-rules/blob/master/src/main/java/org/apache/sling/testing/junit/rules/SlingInstanceRule.java#L44).
IMHO right now it is more intuitive to leverage the {{slingstart-maven-plugin}} with a given
model.txt to create a new launchpad and also start that, instead of using {{o.a.s.testing.serversetup}}.
>  
> For an example leveraging the bootstrapping and starting with {{slingstart-maven-plugin}}
look at https://github.com/apache/sling-org-apache-sling-models-validation-impl/blob/master/pom.xml#L78.
> Currently, any IT annotated with {{@SlingInstanceRule}} fails for this project with an
error like
> {code}
> No files found in jar folder specified by jar.executor.jar.folder property: <somepath>
> 	at org.apache.sling.testing.serversetup.jarexec.JarExecutor.<init>(JarExecutor.java:111)
> 	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:89)
> 	at org.apache.sling.testing.serversetup.instance.SlingTestBase.<init>(SlingTestBase.java:70)
> 	at org.apache.sling.testing.junit.rules.SlingInstanceRule.<clinit>(SlingInstanceRule.java:44)
> 	....
> {code}
> Either this annotation should also support instances started via the slingstart-maven-plugin
or there should be a dedicated annotation for that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message