Mailing-List: contact dev-help@sling.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sling.apache.org
Date: Thu, 2 Nov 2017 09:48:00 +0000 (UTC)
From: "Chetan Mehrotra (JIRA)" <jira@apache.org>
To: dev@sling.apache.org
Message-ID: <JIRA.12667750.1378797488000.129844.1509616080434@Atlassian.JIRA>
In-Reply-To: <JIRA.12667750.1378797488000@Atlassian.JIRA>
References: <JIRA.12667750.1378797488000@Atlassian.JIRA> <JIRA.12667750.1378797488124@jira-lw-us.apache.org>
Subject: [jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging
 data support OSGi aware
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Nov 2017 09:48:05 -0000


    [ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235466#comment-16235466 ] 

Chetan Mehrotra commented on SLING-3049:
----------------------------------------

Thanks [~karlpauls] for the feedback

bq. Obviously, it suffers a little from not being able to get to the real classes - i.e., it will not report on classes that are provided from more than one bundle

Yes. If same package is loaded by multiple bundles then this impl would not provide any info. But in most cases the packages are unique so should be ok for Sling like setup

bq.  I guess the only question I would have is if this could be problematic for tools/scripts/others that rely on a certain layout of a stacktrace. Not sure that is important. 

I mostly use Intellij Stacktrace Analyzer and it is able to work with that

bq. I suppose you could use some bytecode magic to weave the information about the bundle source into the "Source" field of the class and parse it out later when you need it but that probably isn't a good idea

That would be really cool and nifty use of weaving hook!. But for some other day :)

> Make Logback Stacktrace Packaging data support OSGi aware
> ---------------------------------------------------------
>
>                 Key: SLING-3049
>                 URL: https://issues.apache.org/jira/browse/SLING-3049
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Major
>              Labels: logback
>         Attachments: SLING-3049.patch, buildbot-exceptions-while-stopping-jetty.txt
>
>
> Logback provides a useful feature where it dumps the Class packaging Data along with the stacktrace [1]. This provides a quick view of the location from where classes in a given stacktrace are coming. Its default logic does not work properly in OSGi env. Hence it would be useful to patch its logic to become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)