sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (SLING-7258) org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
Date Wed, 22 Nov 2017 07:30:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Carsten Ziegeler reopened SLING-7258:
-------------------------------------

Reopening to address the comments from Konrad and myself on the mailing list:
Konrad: "Only one minor nitpick. I would prefer to fill the field "content" either in the
constructor or in the init method of the StartupFilter....Right now it is lazily filled in
the doFilter which is called from multiple threads at the same time which could lead to reading
the input stream multiple times (due to missing synchronization)."
Carsten: "And if IOUtils.toString throws, the input stream is never closed"
Carsten: "do we really need a dependency to another module to read a file? I
think we should avoid this for this module."

> org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
> --------------------------------------------------------------------------------------------
>
>                 Key: SLING-7258
>                 URL: https://issues.apache.org/jira/browse/SLING-7258
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Starter Startup 1.0.2
>            Reporter: Radu Cotescu
>            Assignee: Radu Cotescu
>             Fix For: Launchpad Builder 10, Starter Startup 1.0.4
>
>         Attachments: starting.png
>
>
> The {{org.apache.sling.starter.startup.impl.StartupFilter}} should return 503 when Sling
is starting, since that's the correct state of the server until it's ready to accept requests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message