sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Pauls (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware
Date Thu, 02 Nov 2017 09:28:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235446#comment-16235446
] 

Karl Pauls commented on SLING-3049:
-----------------------------------

[~chetanm], I think this looks good implementation wise. 

Obviously, it suffers a little from not being able to get to the real classes - i.e., it will
not report on classes that are provided from more than one bundle. Furthermore, the weaving
hook approach will require this bundle to be started as early as possible. However, I can't
think of a better way to achieve this from the top of my head* and fwiw, the weaving hook
implementation looks good (i.e., it doesn't synchronize and loads all classes upfront). I
guess the only question I would have is if this could be problematic for tools/scripts/others
that rely on a certain layout of a stacktrace. Not sure that is important. 

Otherwise, I'm happy with it - nice job.

* I suppose you could use some bytecode magic to weave the information about the bundle source
into the "Source" field of the class and parse it out later when you need it but that probably
isn't a good idea :-)

> Make Logback Stacktrace Packaging data support OSGi aware
> ---------------------------------------------------------
>
>                 Key: SLING-3049
>                 URL: https://issues.apache.org/jira/browse/SLING-3049
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Major
>              Labels: logback
>         Attachments: SLING-3049.patch, buildbot-exceptions-while-stopping-jetty.txt
>
>
> Logback provides a useful feature where it dumps the Class packaging Data along with
the stacktrace [1]. This provides a quick view of the location from where classes in a given
stacktrace are coming. Its default logic does not work properly in OSGi env. Hence it would
be useful to patch its logic to become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message