sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Egli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7121) improved scheduler hc log messages
Date Tue, 12 Sep 2017 10:27:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-7121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162769#comment-16162769
] 

Stefan Egli commented on SLING-7121:
------------------------------------

Improved wording [here|http://svn.apache.org/viewvc?rev=1808103&view=rev]

> improved scheduler hc log messages
> ----------------------------------
>
>                 Key: SLING-7121
>                 URL: https://issues.apache.org/jira/browse/SLING-7121
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Scheduler 2.7.0
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>            Priority: Trivial
>             Fix For: Commons Scheduler 2.7.2
>
>
> Minor fiddle of the scheduler hc log message: [this log output|https://github.com/apache/sling/blob/1a851c2b75f64775fc0a9960ee8b586aef82fecd/bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/SchedulerHealthCheck.java#L155]
could be split into 3:
> * handle the _1_ case separately
> * from the _n_ case
> * plus move the "Thread-dumps can help determine further details about long-running Quartz-Job."
message into a separate log.info
> Plus: simplify the message [here|https://github.com/apache/sling/blob/1a851c2b75f64775fc0a9960ee8b586aef82fecd/bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/SchedulerHealthCheck.java#L119]
as even if runningCount is > 0 (which it could in theory) it would only confuse users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message