sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radu Cotescu (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SLING-7085) Reduce code duplication
Date Fri, 01 Sep 2017 13:18:01 GMT

     [ https://issues.apache.org/jira/browse/SLING-7085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Radu Cotescu closed SLING-7085.
-------------------------------

> Reduce code duplication
> -----------------------
>
>                 Key: SLING-7085
>                 URL: https://issues.apache.org/jira/browse/SLING-7085
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting HTL Engine 1.0.20, Scripting HTL Compiler 1.0.0, Scripting
HTL Java Compiler 1.0.0
>            Reporter: Radu Cotescu
>            Assignee: Radu Cotescu
>             Fix For: Scripting HTL Engine 1.0.38, Scripting HTL Compiler 1.0.12, Scripting
HTL Java Compiler 1.0.12
>
>
> The modularisation of the HTL modules implemented in SLING-5787 introduced some code
duplication:
> * https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/compiler/src/main/java/org/apache/sling/scripting/sightly/impl/compiler/CompileTimeObjectModel.java
> * https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/java-compiler/src/main/java/org/apache/sling/scripting/sightly/render/AbstractRuntimeObjectModel.java
> * https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/runtime/SlingRuntimeObjectModel.java
> To reduce code duplication {{CompileTimeObjectModel}} should be exported as {{ObjectModel}}
and extend its methods with the specifics of each module needing the functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message