sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Munteanu (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SLING-3459) sling:call should not log exceptions with the full stacktrace
Date Wed, 20 Sep 2017 12:09:02 GMT

     [ https://issues.apache.org/jira/browse/SLING-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Munteanu closed SLING-3459.
----------------------------------

> sling:call should not log exceptions with the full stacktrace
> -------------------------------------------------------------
>
>                 Key: SLING-3459
>                 URL: https://issues.apache.org/jira/browse/SLING-3459
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting JSP-Taglib 2.1.8
>            Reporter: Konrad Windszus
>             Fix For: Scripting JSP-Taglib 2.2.2
>
>
> Currently within the sling:call tag all exceptions are both logged on error level and
rethrown (https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/CallTag.java?r=1398589&r=1520554&r=1398589#to139).
That is not a good practice, because the same stack traces would appear twice in the log (once
for the generic exception, logged by the CallTag and once for the wrapped JspException).
> Rather do not log the exception within the CallTag and leave that to other handlers.
 Just rewrapping the exception into the JspException should be enough. No information would
be lost that way, and stack traces would only be logged once (by the code responsible to catch
the JspException).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message