sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karl Pauls <karlpa...@gmail.com>
Subject Re: bnd plugin
Date Fri, 08 Sep 2017 21:11:41 GMT
You want to mark that interface as a ProviderType:

Index: src/main/java/org/apache/sling/pipes/PipeBuilder.java

===================================================================

--- src/main/java/org/apache/sling/pipes/PipeBuilder.java (revision 1807823)

+++ src/main/java/org/apache/sling/pipes/PipeBuilder.java (working copy)

@@ -18,6 +18,7 @@



 import org.apache.sling.api.resource.PersistenceException;

 import org.apache.sling.event.jobs.Job;

+import org.osgi.annotation.versioning.ProviderType;



 import java.util.Map;

 import java.util.Set;

@@ -25,6 +26,7 @@

 /**

  * Builder and Runner of a pipe, based on a fluent API, for script
and java usage.

  */

+@ProviderType

 public interface PipeBuilder {

     /**

      * attach a new pipe to the current context

Index: pom.xml

===================================================================

--- pom.xml (revision 1807823)

+++ pom.xml (working copy)

@@ -265,6 +265,11 @@

       <version>0.0.4</version>

       <scope>test</scope>

     </dependency>

+    <dependency>

+      <groupId>org.osgi</groupId>

+      <artifactId>osgi.annotation</artifactId>

+      <scope>compile</scope>

+    </dependency>

   </dependencies>



 </project>

regards,

Karl

On Fri, Sep 8, 2017 at 10:50 PM, Nicolas Peltier
<peltier.nicolas@gmail.com> wrote:
> Hi,
>
> following sling version policy [0], an API change that doesn't break
> it should be a minor delta (1.2++.3)
>
> but baseline plugin does not seem to like that with a few changes i
> just brought to PipeBuilder api. Bumping to 2.0.0 just because i added
> 3 new methods in an API seems a bit overreacting to me.
>
> Is there some configuration i missed that makes bnd plugin so
> sensitive to change?
>
> Nicolas
>
> [0] https://sling.apache.org/documentation/development/version-policy.html#implementation-bundle-providing-api
>
> [1] [INFO] --- maven-bundle-plugin:3.3.0:baseline (baseline) @
> org.apache.sling.pipes ---
> [INFO] Baseline Report - Generated by Apache Felix Maven Bundle Plugin
> on 2017-09-08T22:38Z based on Bnd - see http://www.aqute.biz/Bnd/Bnd
> [INFO] Comparing bundle org.apache.sling.pipes version 1.0.5-SNAPSHOT
> to version 1.0.4
> [INFO]
> [INFO]   PACKAGE_NAME                                       DELTA
> CUR_VER    BASE_VER   REC_VER    WARNINGS
> [INFO] = ================================================== ==========
> ========== ========== ========== ==========
> [INFO] * org.apache.sling.pipes                             major
> 1.1.0      1.0.0      2.0.0      Version increase required
> [INFO]      > interface org.apache.sling.pipes.PipeBuilder
> [INFO]          + method build(java.lang.String)
> [INFO]              + access abstract
> [INFO]              + return org.apache.sling.pipes.Pipe
> [INFO]          + method ref(java.lang.String)
> [INFO]              + access abstract
> [INFO]              + return org.apache.sling.pipes.PipeBuilder
> [INFO]          + method runWith([Ljava/lang/Object;)
> [INFO]              + access abstract
> [INFO]              + return java.util.Set<Ljava.lang.String;>
> [INFO]      - version 1.0.0
> [INFO]      + version 1.1.0
> [INFO] -----------------------------------------------------------------------------------------------------------
>
> [ERROR] org.apache.sling.pipes: Version increase required; detected
> 1.1.0, suggested 2.0.0
> [INFO] Baseline analysis complete, 1 error(s), 0 warning(s)



-- 
Karl Pauls
karlpauls@gmail.com

Mime
View raw message