sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Lietz <apa...@oliverlietz.de>
Subject Re: bnd plugin
Date Fri, 08 Sep 2017 21:22:29 GMT
On Friday 08 September 2017 22:50:48 Nicolas Peltier wrote:
> Hi,

Hi,

> following sling version policy [0], an API change that doesn't break
> it should be a minor delta (1.2++.3)
> 
> but baseline plugin does not seem to like that with a few changes i
> just brought to PipeBuilder api. Bumping to 2.0.0 just because i added
> 3 new methods in an API seems a bit overreacting to me.
> 
> Is there some configuration i missed that makes bnd plugin so
> sensitive to change?

yes, we should use ProviderType and ConsumerType annotations from org.osgi/	
org.osgi.annotation.versioning/1.0.0 on all exported classes/interfaces.

Regards,
O.

> Nicolas
> 
> [0]
> https://sling.apache.org/documentation/development/version-policy.html#impl
> ementation-bundle-providing-api
> 
> [1] [INFO] --- maven-bundle-plugin:3.3.0:baseline (baseline) @
> org.apache.sling.pipes ---
> [INFO] Baseline Report - Generated by Apache Felix Maven Bundle Plugin
> on 2017-09-08T22:38Z based on Bnd - see http://www.aqute.biz/Bnd/Bnd
> [INFO] Comparing bundle org.apache.sling.pipes version 1.0.5-SNAPSHOT
> to version 1.0.4
> [INFO]
> [INFO]   PACKAGE_NAME                                       DELTA
> CUR_VER    BASE_VER   REC_VER    WARNINGS
> [INFO] = ================================================== ==========
> ========== ========== ========== ==========
> [INFO] * org.apache.sling.pipes                             major
> 1.1.0      1.0.0      2.0.0      Version increase required
> [INFO]      > interface org.apache.sling.pipes.PipeBuilder
> [INFO]          + method build(java.lang.String)
> [INFO]              + access abstract
> [INFO]              + return org.apache.sling.pipes.Pipe
> [INFO]          + method ref(java.lang.String)
> [INFO]              + access abstract
> [INFO]              + return org.apache.sling.pipes.PipeBuilder
> [INFO]          + method runWith([Ljava/lang/Object;)
> [INFO]              + access abstract
> [INFO]              + return java.util.Set<Ljava.lang.String;>
> [INFO]      - version 1.0.0
> [INFO]      + version 1.1.0
> [INFO]
> ---------------------------------------------------------------------------
> --------------------------------
> 
> [ERROR] org.apache.sling.pipes: Version increase required; detected
> 1.1.0, suggested 2.0.0
> [INFO] Baseline analysis complete, 1 error(s), 0 warning(s)


Mime
View raw message