Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D4BA920049B for ; Mon, 14 Aug 2017 09:12:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D313A164563; Mon, 14 Aug 2017 07:12:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 25BEB16453E for ; Mon, 14 Aug 2017 09:12:07 +0200 (CEST) Received: (qmail 37643 invoked by uid 500); 14 Aug 2017 07:12:07 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 37617 invoked by uid 99); 14 Aug 2017 07:12:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2017 07:12:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 99092C02A9 for ; Mon, 14 Aug 2017 07:12:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gmwYt4iBluME for ; Mon, 14 Aug 2017 07:12:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A9BD75F5B3 for ; Mon, 14 Aug 2017 07:12:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 08B7FE0635 for ; Mon, 14 Aug 2017 07:12:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 74F9A2140B for ; Mon, 14 Aug 2017 07:12:02 +0000 (UTC) Date: Mon, 14 Aug 2017 07:12:02 +0000 (UTC) From: "Chetan Mehrotra (JIRA)" To: dev@sling.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 14 Aug 2017 07:12:09 -0000 [ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125315#comment-16125315 ] Chetan Mehrotra commented on SLING-7043: ---------------------------------------- Technically there is NOOP Metrics support also. So we have 2 implementations. > Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction > -------------------------------------------------------------------------- > > Key: SLING-7043 > URL: https://issues.apache.org/jira/browse/SLING-7043 > Project: Sling > Issue Type: Bug > Affects Versions: Commons Metrics 1.0.0 > Reporter: Carsten Ziegeler > Priority: Blocker > Fix For: commons metrics 1.2.4 > > > commons metrics provides a nice abstraction over com.codahale.metrics - however it is exporting com.codahale.metrics.MetricRegistry which seems to be the only way to get at registered metrics objects. Which in turn is completely breaking the purpose of this bundle. > So we should > a) drop exporting that service and avoid leaking internal implementation details > b) create our own version of the registry service -- This message was sent by Atlassian JIRA (v6.4.14#64029)