sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction
Date Mon, 14 Aug 2017 07:12:02 GMT

    [ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125315#comment-16125315
] 

Chetan Mehrotra commented on SLING-7043:
----------------------------------------

Technically there is NOOP Metrics support also. So we have 2 implementations. 

> Exporting  com.codahale.metrics.MetricRegistry is breaking the abstraction
> --------------------------------------------------------------------------
>
>                 Key: SLING-7043
>                 URL: https://issues.apache.org/jira/browse/SLING-7043
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Commons Metrics 1.0.0
>            Reporter: Carsten Ziegeler
>            Priority: Blocker
>             Fix For: commons metrics 1.2.4
>
>
> commons metrics provides a nice abstraction over  com.codahale.metrics - however it is
exporting  com.codahale.metrics.MetricRegistry which seems to be the only way to get at registered
metrics objects. Which in turn is completely breaking the purpose of this bundle.
> So we should
> a) drop exporting that service and avoid leaking internal implementation details
> b) create our own version of the registry service



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message