Mailing-List: contact dev-help@sling.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sling.apache.org
Date: Thu, 29 Jun 2017 21:17:00 +0000 (UTC)
From: "Karl Pauls (JIRA)" <jira@apache.org>
To: dev@sling.apache.org
Message-ID: <JIRA.13082412.1498455852000.138613.1498771020119@Atlassian.JIRA>
In-Reply-To: <JIRA.13082412.1498455852000@Atlassian.JIRA>
References: <JIRA.13082412.1498455852000@Atlassian.JIRA> <JIRA.13082412.1498455852893@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (SLING-6982) JSPC plugin should support
 additional resource roots
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 29 Jun 2017 21:17:04 -0000


     [ https://issues.apache.org/jira/browse/SLING-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Pauls resolved SLING-6982.
-------------------------------
    Resolution: Fixed

Looks good to me. I applied your patch in r1800321. 

Thanks a lot!

> JSPC plugin should support additional resource roots
> ----------------------------------------------------
>
>                 Key: SLING-6982
>                 URL: https://issues.apache.org/jira/browse/SLING-6982
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Maven JSPC Plugin 2.1.0
>            Reporter: Tobias Bocanegra
>            Assignee: Karl Pauls
>             Fix For: Maven JSPC Plugin 2.1.2
>
>
> When trying to compile JSPs that have includes to dependent resources, it is not possible to compile them. you can't put the includes into the same sources, otherwise they will also be compiled.
> suggestion:
> - create new property: {{resourceDirectories}} that is used during resource lookup.
> example:
> {noformat}
>             <plugin>
>                 <artifactId>maven-dependency-plugin</artifactId>
>                 <executions>
>                     <execution>
>                         <id>extract-deps</id>
>                         <phase>generate-sources</phase>
>                         <goals>
>                             <goal>unpack-dependencies</goal>
>                         </goals>
>                         <configuration>
>                             <includeArtifactIds>cq-foundation-content</includeArtifactIds>
>                             <includeTypes>zip</includeTypes>
>                             <excludeTransitive>true</excludeTransitive>
>                             <outputDirectory>${project.build.directory}/dependencies</outputDirectory>
>                         </configuration>
>                     </execution>
>                 </executions>
>             </plugin>
>             <plugin>
>                 <!-- use JSPC plugin to validate the JSPs -->
>                 <groupId>org.apache.sling</groupId>
>                 <artifactId>jspc-maven-plugin</artifactId>
>                 <version>2.1.1-SNAPSHOT</version>
>                 <configuration>
>                     <sourceDirectory>${project.basedir}/jcr_root</sourceDirectory>
>                     <resourceDirectories>
>                         <resourceDirectory>${project.build.directory}/dependencies/jcr_root</resourceDirectory>
>                     </resourceDirectories>
>                     <jasperMappedFile>false</jasperMappedFile>
>                     <jasperKeepGenerated>false</jasperKeepGenerated>
>                     <compilerSourceVM>1.8</compilerSourceVM>
>                     <compilerTargetVM>1.8</compilerTargetVM>
>                 </configuration>
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)