sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-6982) JSPC plugin should support additional resource roots
Date Mon, 26 Jun 2017 05:51:00 GMT

    [ https://issues.apache.org/jira/browse/SLING-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062556#comment-16062556
] 

ASF GitHub Bot commented on SLING-6982:
---------------------------------------

GitHub user tripodsan opened a pull request:

    https://github.com/apache/sling/pull/244

    SLING-6982 JSPC plugin should support additional resource roots

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tripodsan/sling SLING-6982

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit b214389e5e3cf769e69ef9dd0a607923f48c552d
Author: Tobias Bocanegra <tripod@adobe.com>
Date:   2017-06-26T05:49:19Z

    SLING-6982 JSPC plugin should support additional resource roots

----


> JSPC plugin should support additional resource roots
> ----------------------------------------------------
>
>                 Key: SLING-6982
>                 URL: https://issues.apache.org/jira/browse/SLING-6982
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Maven JSPC Plugin 2.1.0
>            Reporter: Tobias Bocanegra
>             Fix For: Maven JSPC Plugin 2.1.2
>
>
> When trying to compile JSPs that have includes to dependent resources, it is not possible
to compile them. you can't put the includes into the same sources, otherwise they will also
be compiled.
> suggestion:
> - create new property: {{resourceDirectories}} that is used during resource lookup.
> example:
> {noformat}
>             <plugin>
>                 <artifactId>maven-dependency-plugin</artifactId>
>                 <executions>
>                     <execution>
>                         <id>extract-deps</id>
>                         <phase>generate-sources</phase>
>                         <goals>
>                             <goal>unpack-dependencies</goal>
>                         </goals>
>                         <configuration>
>                             <includeArtifactIds>cq-foundation-content</includeArtifactIds>
>                             <includeTypes>zip</includeTypes>
>                             <excludeTransitive>true</excludeTransitive>
>                             <outputDirectory>${project.build.directory}/dependencies</outputDirectory>
>                         </configuration>
>                     </execution>
>                 </executions>
>             </plugin>
>             <plugin>
>                 <!-- use JSPC plugin to validate the JSPs -->
>                 <groupId>org.apache.sling</groupId>
>                 <artifactId>jspc-maven-plugin</artifactId>
>                 <version>2.1.1-SNAPSHOT</version>
>                 <configuration>
>                     <sourceDirectory>${project.basedir}/jcr_root</sourceDirectory>
>                     <resourceDirectories>
>                         <resourceDirectory>${project.build.directory}/dependencies/jcr_root</resourceDirectory>
>                     </resourceDirectories>
>                     <jasperMappedFile>false</jasperMappedFile>
>                     <jasperKeepGenerated>false</jasperKeepGenerated>
>                     <compilerSourceVM>1.8</compilerSourceVM>
>                     <compilerTargetVM>1.8</compilerTargetVM>
>                 </configuration>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message