sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SLING-6976) ContentLoader.binaryFile() and ContentLoader.binaryResource() should try to derive mimetype from classpath resource rather than from target property name
Date Wed, 21 Jun 2017 12:51:00 GMT

     [ https://issues.apache.org/jira/browse/SLING-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konrad Windszus updated SLING-6976:
-----------------------------------
    Attachment: SLING-6976-v01.patch

Attached is a proposed patch. [~sseifert@pro-vision.de] Can you have a look?

> ContentLoader.binaryFile() and ContentLoader.binaryResource() should try to derive mimetype
from classpath resource rather than from target property name
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6976
>                 URL: https://issues.apache.org/jira/browse/SLING-6976
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>    Affects Versions: Testing Sling Mock 2.2.12
>            Reporter: Konrad Windszus
>         Attachments: SLING-6976-v01.patch
>
>
> Currently the {{ContentLoader.binaryFile}} tries to derive the mime type from the target
property which should contain the binary (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L226).
This is useless, as the property name almost never contains an extension from which a mimetype
could be derived. Instead the first argument (namely {{classpathResource}} should be taken
as basis to derive the mime type from).
> Currently in practically all cases the mime type will be set to the default value (https://github.com/apache/sling/blob/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/loader/ContentLoader.java#L466)
which is {{application/octet-stream}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message