sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Edelson (JIRA)" <>
Subject [jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name
Date Fri, 05 May 2017 14:42:04 GMT


Justin Edelson commented on SLING-6804:

[~henzlerg] I have several concerns with your design and the implementation resulting from

1. It does not differentiate between names and tags. There is nothing currently documented
that I can find discouraging the use of conflicting names between tags and names so the wrong
checks may be selected, i.e. I want a HC named "foo" but I actually get the HC with that name
and all of the HCs tagged "foo".
2. It misses the key point that names should always be ORd whereas tags can be ORd or ANDd.
Requesting names "foo" and "bar" should return both whereas tags "foo" and "bar" can either
be the intersection or the union, depending upon the user requests. Unless we want tags to
always be ORd, but that is a non-backwards compatible behavioral change.
3. Changing the behavior of the implementation in this way violates the contract expressed
by the interface. The interface says "Executes all health checks with the supplied list of
tags.". Now that isn't the case. If we change the contract, we still need to increment the
API version. The advantage of doing this in the manner I provided is that the change is backwards
compatible to consumers.

FWIW, I disagree with the analogy to Google. Google's operators are explicitly named (e.g.
{{site:}}) or determined based on a prefix (e.g. {{$500}}).

> Request to allow the health check servlet to directly query a single health check by
> -----------------------------------------------------------------------------------------
>                 Key: SLING-6804
>                 URL:
>             Project: Sling
>          Issue Type: Improvement
>          Components: Health Check
>            Reporter: Clinton H Goudie-Nice
>            Assignee: Justin Edelson
>            Priority: Minor
>         Attachments:, SLING-6804.diff
> AMS has a request to be able to access an individual health check by name
> For example: 
> http://localhost:4502/system/health/named/Sling%20Get%20Servlet.json
> And have it return the results for only this named health check.

This message was sent by Atlassian JIRA

View raw message