sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Sanso (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
Date Tue, 28 Mar 2017 13:13:41 GMT

    [ https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945118#comment-15945118
] 

Antonio Sanso commented on SLING-6703:
--------------------------------------

[~kwin] just guessing, the fact that you do not see anymore this issue might be a direct consequence
of the loginAdministrative refactor done lately....

> Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
> -----------------------------------------------------------------------------------
>
>                 Key: SLING-6703
>                 URL: https://issues.apache.org/jira/browse/SLING-6703
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlets Post 2.3.14
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}} (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
always ignores the given {{Throwable}} and just creates a new generic {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which occur in the
response body, the given exception should not be wrapped but just the given throwable's message
text should be given out in the document.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message