sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Seifert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.*
Date Fri, 24 Mar 2017 16:33:41 GMT

    [ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940670#comment-15940670
] 

Stefan Seifert commented on SLING-6679:
---------------------------------------

i had a look as the patch from SLING-6694 - looks good to me.

one general question left: should we create a static instance of the factories like JsonReaderFactory?
this would avoid looking up the json provider and intializing it again on every invocation.
according to http://docs.oracle.com/javaee/7/api/javax/json/JsonReaderFactory.html it's threadsafe.
same applies to the other factories.

on the other hand this may be a premature optimization, i've no metrics if it really helps.

> Replace usage of org.apache.sling.commons.json.*
> ------------------------------------------------
>
>                 Key: SLING-6679
>                 URL: https://issues.apache.org/jira/browse/SLING-6679
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we need to replace
its usage everywhere else (at least if we want to be able to release other modules that depend
on it). 
> This is the umbrella issue for getting this done. The idea is to create sub-issues with
patches for individual components, review the patches, and when all are done: close this issue.

> General discussions and problems should go to this issue and specific ones on the sub-issue
in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message