Mailing-List: contact dev-help@sling.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sling.apache.org
MIME-Version: 1.0
From: Matt Ryan <oss@mvryan.org>
Date: Fri, 3 Feb 2017 16:29:31 -0700
Message-ID: <CABJVO158_NTDWA2NBuonzd2e+CDPQxuUnSML1DS_WP-UtNqWxA@mail.gmail.com>
Subject: [unit testing] HtmlRenderer error cases
To: dev@sling.apache.org
Content-Type: multipart/alternative; boundary=94eb2c184c3261e2370547a8a7f0
archived-at: Fri, 03 Feb 2017 23:29:37 -0000

--94eb2c184c3261e2370547a8a7f0
Content-Type: text/plain; charset=UTF-8

Hi,

As I'm in the process of adding unit tests for HtmlRenderer, I'm wondering
about some cases that could arguably be error conditions.

For example, if I have an HtmlRenderer instance and I call the "link()"
method with an empty string passed in as the info parameter, the method
will faithfully generate an anchor tag that is not wrapped around any
text.  Likewise, if I call the "link()" method with an empty string passed
in as the url parameter, it will also generate an anchor tag with an empty
string value for the href.

Do we prefer to make these methods accept as many inputs as possible, or
would we like to make use of e.g. IllegalArgumentException to indicate when
the method is being invoked in a way that doesn't make sense?

I just want to know the general feeling, so I can consistently enforce it
via the unit tests I'm writing.


-MR

--94eb2c184c3261e2370547a8a7f0--