sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin
Date Tue, 10 Jan 2017 13:14:59 GMT

    [ https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814940#comment-15814940
] 

Konrad Windszus commented on SLING-6344:
----------------------------------------

[~rombert] Ok, I see. Since I reverted the patch anyhow for other issues that should currently
be no longer an issue. Before I come up with a new patch I would like to get your opinion
also on the general semantics that no import/export should take place for nodes in a project
not having a filter.xml. Currently at least the {{o.a.s.ide.eclipse.ui.internal.ExportWizardPage}}
and {{ImportWizardPage}} assume that in such a case everything is imported/exported (and some
ITs also rely on that behaviour). If I change the semantics I would need to change those places
as well. WDYT?

> Support filter.xmls being generated by the content-package-maven-plugin
> -----------------------------------------------------------------------
>
>                 Key: SLING-6344
>                 URL: https://issues.apache.org/jira/browse/SLING-6344
>             Project: Sling
>          Issue Type: Bug
>          Components: IDE
>    Affects Versions: Sling Eclipse IDE 1.1.0
>            Reporter: Konrad Windszus
>            Priority: Critical
>         Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the source directory,
but also generate or merge filter.xmls. Therefore Sling IDE should consider only the filter.xml
in the generated artifacts (package). The problem with that is, that content-package-maven-plugin
does only generate that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the method {{ResourceChangeCommandFactory#getFilterResult}}
returns {{ALLOW}} while it should return {{DENY}} to not overwrite any nodes in case the filter
rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType of the root
node in the JCR from {{rep:root}} to {{nt:unstructured}} and the resourceType from {{sling:redirect}}
to just being removed which breaks the redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message