Mailing-List: contact dev-help@sling.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sling.apache.org
Received-SPF: unknown (athena.apache.org: error in processing during lookup of
 fmeschbe@adobe.com)
From: Felix Meschberger <fmeschbe@adobe.com>
To: "dev@sling.apache.org" <dev@sling.apache.org>
Subject: Re: [osgi] Using Inventory API in Commons Log
Thread-Topic: [osgi] Using Inventory API in Commons Log
Thread-Index: AQHPILwJL5QiDFNgukO/k6KxkyzZHJqjOL8A
Date: Mon, 3 Feb 2014 08:51:23 +0000
Message-ID: <9DABDE99-222C-493A-BB71-9D08E64ABBA3@adobe.com>
References: 
 <CAHCW-mmZtjWchDyOMV7irO++oMzvvGi7Q8W89SB4PNO8xTeZQw@mail.gmail.com>
In-Reply-To: 
 <CAHCW-mmZtjWchDyOMV7irO++oMzvvGi7Q8W89SB4PNO8xTeZQw@mail.gmail.com>
Accept-Language: de-CH, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5241A6161F15984296C45431537E2F1C@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi

Am 03.02.2014 um 09:41 schrieb Chetan Mehrotra <chetan.mehrotra@gmail.com>:

> Hi,
>=20
> For SLING-3264 I was thinking to provide Inventory integration in
> Commons Logs. However the Commons Log bundle starts at level 1 while
> the Inventory bundle starts at Level 5. The log bundle would use the
> ServiceFactory approach to expose the Inventory service and would not
> have required dependency on Inventory API.
>=20
> So just wanted to confirm that would it be fine to depend on classes
> from a bundle which starts at later start level or not?

Sure. This is what we are using ServiceFactory and dynamic/delayed import a=
ll over places. See for example the Configuration Admin binding the Apache =
Felix SCR bundle.

So, what seems to boild down to kind of a best practice is to:

  * use ServiceFactory for optional services
  * use Import-Package with resolution:=3Doptional to have=20
      static wiring if possible
  * use DynamicImport-Package to have dynamic wiring
      on-demand

It is just very important to thouroughly test this to not get inadvertend C=
lassNotFoundExceptions, for example if the optional classes appear in the m=
ethod signature of a required class (see the ResourceResolverActivator.getF=
eaures() method which returns Object to work around this issue).

Regards
Felix=