sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Egli <e...@adobe.com>
Subject Re: [discovery] including commons-net
Date Wed, 05 Feb 2014 12:22:29 GMT
Yes, I'm only using that one atm. So inlining sounds like a good idea!

Cheers,
Stefan

On 2/5/14 12:26 PM, "Chetan Mehrotra" <chetan.mehrotra@gmail.com> wrote:

>If you are only going to use SubnetUtils [1] then we can possibly
>inline it in the bundle as it appears to be not depending on any other
>class in commons-net
>
>Chetan Mehrotra
>[1] 
>https://github.com/apache/commons-net/blob/trunk/src/main/java/org/apache/
>commons/net/util/SubnetUtils.java
>
>
>On Wed, Feb 5, 2014 at 4:44 PM, Stefan Egli <egli@adobe.com> wrote:
>> Just checked.
>>
>> The exports look clean: only org.apache.commons.net.*
>>
>> The imports too: javax.crypto,javax.crypto.spec,javax.net,javax.net.ssl
>>
>> But the size is not tremendously small - it is 280kB.. - but within the
>> range of the other apache's commons-*
>>
>> Cheers,
>> Stefan
>>
>> On 2/5/14 11:53 AM, "Bertrand Delacretaz" <bdelacretaz@apache.org>
>>wrote:
>>
>>>Hi Stefan,
>>>
>>>On Wed, Feb 5, 2014 at 11:46 AM, Stefan Egli <egli@adobe.com> wrote:
>>>> ...For implementing SLING-3001 I'd like to include apache's
>>>>commons-net
>>>>(3.3) as it contains a nice utility
>>>> for doing CIDR and mask calculations (SubnetUtils)....
>>>
>>>What does that mean, is that just a new small bundle with clean
>>>package exports/imports?
>>>
>>>If yes I'm ok with it.
>>>
>>>-Bertrand
>>


Mime
View raw message