sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SLING-2094) Adding support to call a sling resource for JSP page exception handler <%@ page errorPage ... %>
Date Thu, 30 Jun 2011 09:08:28 GMT

    [ https://issues.apache.org/jira/browse/SLING-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057701#comment-13057701
] 

Carsten Ziegeler commented on SLING-2094:
-----------------------------------------

Many thanks for your patch, Antonio - I've attached a revised version of your patch (not sure
if it is 100%).
The basic difference is that the error page information is transported inside the SlingPageException
instead of adding it as a request attribute.

In addition, I'm not 100% sure if we should abort rendering if the error page is invoked -
the question here is how we see the semantics of this - is this an error handler for this
jsp or for the whole response. I tend to see this as an error handler for this jsp and would
resume with rendering. Otherwise we would have to reset the response before invoking the error
script

> Adding support to call a sling resource for JSP page exception handler  <%@ page errorPage
... %>
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-2094
>                 URL: https://issues.apache.org/jira/browse/SLING-2094
>             Project: Sling
>          Issue Type: New Feature
>          Components: Scripting
>            Reporter: Antonio Sanso
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: Scripting JSP 2.0.18
>
>         Attachments: SLING-2094-asanso-patch.txt, SLING-2094-asanso2-patch.txt, SLING-2094-asanso3-patch.txt,
SLING-2094-asanso4-patch.txt, SLING-2094-integration-tests.patch, scripting.patch
>
>
> At the moment the JSP page exception handler (<%@ page errorPage ... %>) is not
supported as the jsp engine can't resolve the path to the jsp if  this is a repository resource.
> See also the user mailing list  [0] for more details
> [0] http://www.mail-archive.com/users@sling.apache.org/msg01369.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message