Return-Path: Delivered-To: apmail-sling-dev-archive@www.apache.org Received: (qmail 57846 invoked from network); 9 Aug 2010 17:08:52 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Aug 2010 17:08:52 -0000 Received: (qmail 92355 invoked by uid 500); 9 Aug 2010 17:08:52 -0000 Delivered-To: apmail-sling-dev-archive@sling.apache.org Received: (qmail 92310 invoked by uid 500); 9 Aug 2010 17:08:51 -0000 Mailing-List: contact dev-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list dev@sling.apache.org Received: (qmail 92302 invoked by uid 99); 9 Aug 2010 17:08:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Aug 2010 17:08:51 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of eric.d.norman@gmail.com designates 209.85.161.178 as permitted sender) Received: from [209.85.161.178] (HELO mail-gx0-f178.google.com) (209.85.161.178) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Aug 2010 17:08:43 +0000 Received: by gxk10 with SMTP id 10so3499616gxk.9 for ; Mon, 09 Aug 2010 10:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:received :in-reply-to:references:date:message-id:subject:from:to:content-type; bh=WPRY9Hm3Ku3T53+OGTQKC5mC2JpVyh5VdrxFUg/p008=; b=Vplf7gsMa0aDP9kp0QgHFJP5BbHb0eRUMmmP9K083+OdHcdUAHeKWdjazBFd7DwXjB wD7jZNv3aaM3jt3toZ2nI1QoAnxfaVh4phbuOmBOu5tdsrRvmToNltN23QAOovep0uiY 65huoRicXXpmUF9Usjnw1/AKdXOPWmrQ8z3jg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=kBLkdi07xc11WVr4vLRTztLvIHYTUUwgroQXlgi5xd8KQIeF7j77Uaf+/bw/UWAavc hOAr2UyPBqStTYloz371y9+skPap9QCBWWO9nrq+qHCXFAFsU0mwXvEfL24kcJPhEEez fF5aSLabCOdkfzl5JyHbz5iQf4bwUeGpDU1w4= MIME-Version: 1.0 Received: by 10.100.8.2 with SMTP id 2mr18188321anh.165.1281373702194; Mon, 09 Aug 2010 10:08:22 -0700 (PDT) Received: by 10.231.10.141 with HTTP; Mon, 9 Aug 2010 10:08:21 -0700 (PDT) Received: by 10.231.10.141 with HTTP; Mon, 9 Aug 2010 10:08:21 -0700 (PDT) In-Reply-To: References: <6681F5FD-0F9D-4F71-BE40-18076BABE916@meltmedia.com> <7FA2621F-0845-4422-87F1-65702A2EE509@gmail.com> Date: Mon, 9 Aug 2010 10:08:21 -0700 Message-ID: Subject: Re: Allow modify during "import" operation From: Eric Norman To: dev@sling.apache.org Content-Type: multipart/alternative; boundary=0016e644c30a5805cb048d671034 X-Virus-Checked: Checked by ClamAV on apache.org --0016e644c30a5805cb048d671034 Content-Type: text/plain; charset=ISO-8859-1 Hi all, I reviewed the patch and checked in the changes with a few minor modifications. Please verify that that the changes will work for your use cases. Regards, Eric On Aug 6, 2010 12:41 AM, "Bertrand Delacretaz" wrote: On Thu, Aug 5, 2010 at 7:36 PM, Simon Gaeremynck wrote: > This issue has bee... >... > [1] https://issues.apache.org/jira/browse/SLING-1627 Looking at that patch, Zach reused the existing ImportOptions.isOverwrite() flag, instead of defining a new isPropertyOverwrite() one as some of us suggested. I think that introduces an incompatible change, whereas defining a new option means that old code would continue to work unchanged. -Bertrand --0016e644c30a5805cb048d671034--