sling-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Müller (JIRA) <j...@apache.org>
Subject [jira] Resolved: (SLING-1701) contrib/scripting/velocity VelocityTemplatesScriptEngine has multiple issues
Date Mon, 30 Aug 2010 20:19:56 GMT

     [ https://issues.apache.org/jira/browse/SLING-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mike Müller resolved SLING-1701.
--------------------------------

    Resolution: Duplicate

> contrib/scripting/velocity VelocityTemplatesScriptEngine has multiple issues
> ----------------------------------------------------------------------------
>
>                 Key: SLING-1701
>                 URL: https://issues.apache.org/jira/browse/SLING-1701
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>         Environment: Felix 1.4, Sling 2.0.7, Apache Velocity 1.6.2 
>            Reporter: Olaf Otto
>            Assignee: Mike Müller
>            Priority: Critical
>         Attachments: VelocityTemplatesScriptEngine.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Affects: Rev. 989119 of https://svn.apache.org/repos/asf/sling/trunk/contrib/scripting/velocity
(2.0.0-SNAPSHOT) 
> The VelocityTemplatesScriptEngine has several issues, such as bad exception handling
(catching Throwable instead of Exception), potential NPE's and bad naming, discarding of exception
stacktrace and misleading error messages, missing Javadoc. Attached is a refactored version
of the class. Note that there are still some opened questions marked with //TODO.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message