sling-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-installer-factory-feature] bosschaert commented on a change in pull request #1: SLING-9658 Support binary archives in .far files
Date Tue, 01 Sep 2020 14:38:39 GMT

bosschaert commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-feature/pull/1#discussion_r481187728



##########
File path: src/main/java/org/apache/sling/installer/factory/model/impl/FeatureModelInstallerPlugin.java
##########
@@ -102,6 +104,9 @@
 
     private final File storageDirectory;
 
+    @Reference
+    private volatile List<ExtensionHandler> extensionHandlers;
+

Review comment:
       Yes, as per Declarative Services spec. However I forgot that it's not greedy by default.
So I added explicit selectors for this now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message