sling-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented on a change in pull request #7: SLING-8447 - Add gauge for current retries per subscriber
Date Fri, 31 May 2019 13:11:32 GMT
cschneider commented on a change in pull request #7: SLING-8447 - Add gauge for current retries
per subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/7#discussion_r289382900
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java
 ##########
 @@ -278,6 +278,9 @@ public void activate(SubscriberConfiguration config, BundleContext context,
Map<
                 format("Queue Processor for Subscriber agent %s", subAgentName));
 
         sender = messagingProvider.createSender();
+        
+        String nameRetries = DistributionMetricsService.SUB_COMPONENT + "." + config.name()
+ ".current_retries";
 
 Review comment:
   It would make a lot of sense to distinguish the gauges with properties. I am not sure though
if it can be done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message