sling-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on a change in pull request #7: SLING-8447 - Add gauge for current retries per subscriber
Date Fri, 31 May 2019 12:42:52 GMT
tmaret commented on a change in pull request #7: SLING-8447 - Add gauge for current retries
per subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/7#discussion_r289373479
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java
 ##########
 @@ -278,6 +278,9 @@ public void activate(SubscriberConfiguration config, BundleContext context,
Map<
                 format("Queue Processor for Subscriber agent %s", subAgentName));
 
         sender = messagingProvider.createSender();
+        
+        String nameRetries = DistributionMetricsService.SUB_COMPONENT + "." + config.name()
+ ".current_retries";
 
 Review comment:
   IIUC, the subscriber name (`config.name()`) is being used to allow distinguishing the metric
source. It makes sense to be able to distinguish the metric source using the config.name().
However, we should avoid named metrics as they are hard to manage. Couldn't we emit the subscriber
name as a property of the gauge ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message