Return-Path: Delivered-To: apmail-sling-commits-archive@www.apache.org Received: (qmail 64912 invoked from network); 11 Aug 2010 11:31:00 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Aug 2010 11:31:00 -0000 Received: (qmail 19205 invoked by uid 500); 11 Aug 2010 11:30:59 -0000 Delivered-To: apmail-sling-commits-archive@sling.apache.org Received: (qmail 19143 invoked by uid 500); 11 Aug 2010 11:30:58 -0000 Mailing-List: contact commits-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list commits@sling.apache.org Received: (qmail 19136 invoked by uid 99); 11 Aug 2010 11:30:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Aug 2010 11:30:57 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Aug 2010 11:30:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 86EE023889E5; Wed, 11 Aug 2010 11:29:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r984374 - in /sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr: JcrNodeResource.java JcrPropertyResource.java Date: Wed, 11 Aug 2010 11:29:36 -0000 To: commits@sling.apache.org From: fmeschbe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100811112936.86EE023889E5@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: fmeschbe Date: Wed Aug 11 11:29:36 2010 New Revision: 984374 URL: http://svn.apache.org/viewvc?rev=984374&view=rev Log: SLING-1414 Make JcrNodeResource and JcrProperty resource package private. For one they are not required to be public and second the BeanELResolver will not be able to call the Resource interface methods implemented by the JcrItemResource class if they are public. See the issue for full details. Modified: sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrPropertyResource.java Modified: sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java URL: http://svn.apache.org/viewvc/sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java?rev=984374&r1=984373&r2=984374&view=diff ============================================================================== --- sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java (original) +++ sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java Wed Aug 11 11:29:36 2010 @@ -51,7 +51,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** A Resource that wraps a JCR Node */ -public class JcrNodeResource extends JcrItemResource { +class JcrNodeResource extends JcrItemResource { /** marker value for the resourceSupertType before trying to evaluate */ private static final String UNSET_RESOURCE_SUPER_TYPE = ""; Modified: sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrPropertyResource.java URL: http://svn.apache.org/viewvc/sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrPropertyResource.java?rev=984374&r1=984373&r2=984374&view=diff ============================================================================== --- sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrPropertyResource.java (original) +++ sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrPropertyResource.java Wed Aug 11 11:29:36 2010 @@ -35,7 +35,7 @@ import org.apache.sling.api.resource.Res import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class JcrPropertyResource extends JcrItemResource { +class JcrPropertyResource extends JcrItemResource { /** default log */ private final Logger log = LoggerFactory.getLogger(getClass());