skywalking-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #15: Trace series module
Date Tue, 13 Jul 2021 06:14:10 GMT

hanahmily commented on a change in pull request #15:
URL: https://github.com/apache/skywalking-banyandb/pull/15#discussion_r668456935



##########
File path: api/common/id.go
##########
@@ -17,4 +17,9 @@
 
 package common
 
-type ChunkID uint64
+type ChunkID []byte
+type SeriesID uint64

Review comment:
       It's the routing key that is defined in `sw/trace_series.json`. Liaison leverages it
to determine which shard a segment should be forward. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message