From notifications-return-100239-archive-asf-public=cust-asf.ponee.io@skywalking.apache.org Mon Nov 23 07:52:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id CE512180654 for ; Mon, 23 Nov 2020 08:52:28 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 85633638FF for ; Mon, 23 Nov 2020 07:52:25 +0000 (UTC) Received: (qmail 4875 invoked by uid 500); 23 Nov 2020 07:52:24 -0000 Mailing-List: contact notifications-help@skywalking.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@skywalking.apache.org Delivered-To: mailing list notifications@skywalking.apache.org Received: (qmail 4866 invoked by uid 99); 23 Nov 2020 07:52:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2020 07:52:24 +0000 From: =?utf-8?q?GitBox?= To: notifications@skywalking.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bskywalking=5D_codecov=5Bbot=5D_edited_a_comment_on?= =?utf-8?q?_pull_request_=235835=3A_Observing_Istio_control_plane_?= Message-ID: <160611794468.15632.17000635436479145003.asfpy@gitbox.apache.org> Date: Mon, 23 Nov 2020 07:52:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) (42fc31f) into [master](https://codecov.io/gh/apache/skywalking/commit/8d164d3dd8c35cdafe683abc7fd9f4e4b530808f?el=desc) (8d164d3) will **decrease** coverage by `1.23%`. > The diff coverage is `46.15%`. [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5835 +/- ## ============================================ - Coverage 51.20% 49.96% -1.24% + Complexity 3488 3322 -166 ============================================ Files 1659 1663 +4 Lines 35650 35733 +83 Branches 3910 3911 +1 ============================================ - Hits 18254 17854 -400 - Misses 16489 16968 +479 - Partials 907 911 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.14% <ø> (ø)` | `20.00 <0.00> (ø)` | | | [...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | | | [...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `16.66% <16.66%> (ø)` | `3.00 <3.00> (?)` | | | [...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh) | `40.00% <50.00%> (-20.00%)` | `3.00 <0.00> (ø)` | | | [.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==) | `70.58% <55.55%> (ø)` | `5.00 <1.00> (ø)` | | | ... and [74 more](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=footer). Last update [8d164d3...42fc31f](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org