From notifications-return-100071-archive-asf-public=cust-asf.ponee.io@skywalking.apache.org Sun Nov 22 14:56:20 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 7D25F180686 for ; Sun, 22 Nov 2020 15:56:20 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id B0D5B46718 for ; Sun, 22 Nov 2020 14:56:19 +0000 (UTC) Received: (qmail 28218 invoked by uid 500); 22 Nov 2020 14:56:19 -0000 Mailing-List: contact notifications-help@skywalking.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@skywalking.apache.org Delivered-To: mailing list notifications@skywalking.apache.org Received: (qmail 28208 invoked by uid 99); 22 Nov 2020 14:56:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Nov 2020 14:56:19 +0000 From: =?utf-8?q?GitBox?= To: notifications@skywalking.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bskywalking=5D_codecov=5Bbot=5D_edited_a_comment_on?= =?utf-8?q?_pull_request_=235844=3A_add_Tidb_provider_module=2E?= Message-ID: <160605697941.15632.10306400575740628655.asfpy@gitbox.apache.org> Date: Sun, 22 Nov 2020 14:56:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (590bea7) into [master](https://codecov.io/gh/apache/skywalking/commit/e8f30f91b15d28d012dd7ea451e3189a228cee37?el=desc) (e8f30f9) will **increase** coverage by `1.55%`. > The diff coverage is `85.52%`. [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5844/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5844 +/- ## ============================================ + Coverage 51.08% 52.64% +1.55% - Complexity 3468 3486 +18 ============================================ Files 1656 901 -755 Lines 35577 22636 -12941 Branches 3905 2189 -1716 ============================================ - Hits 18176 11916 -6260 + Misses 16493 9759 -6734 - Partials 908 961 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `81.81% <81.81%> (ø)` | `6.00 <6.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `88.00% <88.00%> (ø)` | `9.00 <9.00> (?)` | | | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `63.38% <100.00%> (+12.67%)` | `13.00 <0.00> (+1.00)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | ... and [1159 more](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=footer). Last update [e8f30f9...590bea7](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org