skywalking-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [skywalking] wu-sheng commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event
Date Sun, 29 Nov 2020 03:36:57 GMT

wu-sheng commented on a change in pull request #5914:
URL: https://github.com/apache/skywalking/pull/5914#discussion_r532149660



##########
File path: apm-sniffer/config/logconfig.yaml
##########
@@ -0,0 +1,12 @@
+- name: "log4j"
+  packages:
+    - "*"
+  level: "error"
+- name: "log4j2"
+  packages:
+    - "*"
+  level: "error"
+- name: "logback"
+  packages:
+    - "*"
+  level: "error"

Review comment:
       2 things, 
   1. Why use YAML
   1. If use properties, the agent core has provided the full capability to extend your own
format. Recommend to adopt that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message