skywalking-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wush...@apache.org
Subject [skywalking-rocketbot-ui] branch master updated: fix: vue props warn in development mode (#229)
Date Mon, 13 Jan 2020 04:52:50 GMT
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git


The following commit(s) were added to refs/heads/master by this push:
     new e367dad  fix: vue props warn in development mode (#229)
e367dad is described below

commit e367dadfa1dd02f18517bcd0917ad9ae214e8138
Author: leemove <hg_limu@163.com>
AuthorDate: Mon Jan 13 12:52:42 2020 +0800

    fix: vue props warn in development mode (#229)
    
    * fix: vue props warn in development mode
    
    * Update trace-search.vue
    
    Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
    Co-authored-by: Allen Wang <Allen.Wang.123@outlook.com>
---
 src/views/components/trace/trace-search.vue | 2 +-
 src/views/containers/alarm.vue              | 2 +-
 src/views/containers/trace.vue              | 6 ++++++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/views/components/trace/trace-search.vue b/src/views/components/trace/trace-search.vue
index e5ab4b2..ebcd9ff 100644
--- a/src/views/components/trace/trace-search.vue
+++ b/src/views/components/trace/trace-search.vue
@@ -118,7 +118,7 @@ export default class TraceSearch extends Vue {
   @Mutation('rocketTrace/SET_TRACE_FORM_ITEM') private SET_TRACE_FORM_ITEM: any;
   @Prop({ default: false, type: Boolean })
   private inTopo!: boolean;
-  @Prop({ default: { label: 'All', key: '' } })
+  @Prop({ default: () => ({label: 'All', key: ''})})
   private propsService!: Option;
   private service: Option = {label: 'All', key: ''};
   private time!: Date[];
diff --git a/src/views/containers/alarm.vue b/src/views/containers/alarm.vue
index af58623..360eadd 100644
--- a/src/views/containers/alarm.vue
+++ b/src/views/containers/alarm.vue
@@ -39,7 +39,7 @@ import { State, Action, Getter } from 'vuex-class';
 export default class Alarm extends Vue {
   @State('rocketAlarm') private rocketAlarm!: any;
   @Getter('durationTime') private durationTime: any;
-  @Prop({default: {label: 'All', key: ''}})
+  @Prop({default: () => ({label: 'All', key: ''})})
   private alarmScope: any;
   @Prop({default: false, type: Boolean})
   private inTopo!: boolean;
diff --git a/src/views/containers/trace.vue b/src/views/containers/trace.vue
index e4d516c..0f998a1 100644
--- a/src/views/containers/trace.vue
+++ b/src/views/containers/trace.vue
@@ -43,6 +43,12 @@ export default class Trace extends Vue {
   @Action('rocketTrace/GET_TRACELIST') private GET_TRACELIST: any;
   @Action('rocketTrace/GET_TRACE_SPANS') private GET_TRACE_SPANS: any;
 
+  @Prop({default: () => ({label: 'All', key: ''})})
+  private service!: Option;
+
+  @Prop({default: false, type: Boolean})
+  private inTopo!: boolean;
+
   private show: boolean = true;
   private beforeCreate() {
     this.$store.registerModule('rocketTrace', trace);


Mime
View raw message