sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "M. Le Bihan (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SIS-188) Hide FieldDescriptor (a DBase3 internal format structure)
Date Sun, 22 Nov 2015 19:23:11 GMT

     [ https://issues.apache.org/jira/browse/SIS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

M. Le Bihan resolved SIS-188.
-----------------------------
       Resolution: Done
         Assignee: M. Le Bihan
    Fix Version/s: 0.7

The descriptor has these public methods :

    public int getDecimalCount()
    public int getLength()
    public String getName()
    public DBaseDataType getType()

that return String and int rather than bytes.

and the DBaseFieldDescritor has been moved to an internal package.

> Hide FieldDescriptor (a DBase3 internal format structure)
> ---------------------------------------------------------
>
>                 Key: SIS-188
>                 URL: https://issues.apache.org/jira/browse/SIS-188
>             Project: Spatial Information Systems
>          Issue Type: Sub-task
>          Components: Shapefile
>            Reporter: Martin Desruisseaux
>            Assignee: M. Le Bihan
>              Labels: JDBC, Shapefile
>             Fix For: 0.7
>
>
> The {{org.apache.sis.storage.shapefile}} package contains a {{FieldDescriptor}} public
class, which contain information that look likes very specific to the internal of DBase format.
For example:
> * Field name as an array of bytes (this is not what user would usually handle, which
are rather {{String}} objects)
> * Field address in memory (maybe an heritage from C/C++ ?)
> * DBase+ Lan Reserved 2 (not sure what it is, documentation only said "reserved 2")
> Those internal details should not be visible to the users. I suggest to either declare
the class package-privated, or move it to an internal package.
> The {{FieldDescriptors}} class, which is a list of {{FieldDescriptor}}, should also move
in the same way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message