sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1565708 - in /sis/ip-review: ./ rev/07848/ rev/10796/ rev/20874/ rev/24868/ rev/26669/
Date Fri, 07 Feb 2014 16:07:19 GMT
Author: desruisseaux
Date: Fri Feb  7 16:07:19 2014
New Revision: 1565708

URL: http://svn.apache.org/r1565708
Log:
IP review for JUnit test files.

Added:
    sis/ip-review/ImagingParametersTest.xhtml   (with props)
    sis/ip-review/ParametersTest.xhtml   (with props)
    sis/ip-review/rev/07848/ParametersTest.xhtml   (with props)
    sis/ip-review/rev/10796/ParametersTest.xhtml   (with props)
    sis/ip-review/rev/20874/ImagingParametersTest.xhtml   (with props)
    sis/ip-review/rev/20874/ParametersTest.xhtml   (with props)
    sis/ip-review/rev/24868/ImagingParametersTest.xhtml   (with props)
    sis/ip-review/rev/26669/ParametersTest.xhtml   (with props)

Added: sis/ip-review/ImagingParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ImagingParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/ImagingParametersTest.xhtml (added)
+++ sis/ip-review/ImagingParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ImagingParametersTest history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ImagingParametersTest history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ImagingParametersTest.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31132</td><td>2008-08-05</td><td>desruisseaux</td><td>As a side effect of "geotidy" work, ported a few bug fixes in metadata. Avoid usage of deprecated GeneralName.getScope() method, replaced by scope().</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28051</td><td>2007-11-26</td><td>desruisseaux</td><td>More Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should returns a set of Identifiers, not a set of Strings).</td></tr>
+<tr><td class="rev">27847</td><td>2007-11-12</td><td>desruisseaux</td><td>Replaced some references to 'org.geotools.util' by references to 'org.geotools.util.logging'. Removed the old classes to make sure that there is no more accidental references. Note that the old classes will not be removed from the 2.4 branch.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26802</td><td>2007-08-31</td><td>desruisseaux</td><td>Merged changes from the 2.4 branch relative to the retrofitting of ImagingParametersDescriptor functionalities in its ImagingParameters parent class.</td></tr>
+<tr><td class="rev">25262</td><td>2007-04-23</td><td>desruisseaux</td><td>Finished review of metadata and factory hints change. Fixed a potential glitch in parameter names handling (some code were disabled in AbstractIdentifiedObject apparently in order to avoid a ClassCastException caused by the spit of org.opengis.metadata.Identifier in two interfaces, Identifier and ReferenceIdentifier. Fixed the exception and reenabled the code). Not sure yet what the consequence was. It may help for the stereographic projection issue, but need to check.</td></tr>
+<tr><td class="rev">24868</td><td>2007-03-22</td><td class="unav">jgarnett</td><td><a href="rev/24868/ImagingParametersTest.xhtml">clean up metadata and referencing in response to GEO-93</a></td></tr>
+<tr><td class="rev">24576</td><td>2007-02-24</td><td>desruisseaux</td><td>Renamed 'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming. Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique' was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match more closely the common usage. In addition, also renamed some JUnit test classes in an attempt to make clearer what they are testing.</td></tr>
+<tr><td class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced the use of some deprecated methods (MonolineFormatter.initGeotools --> Logging.forceMonolineConsoleOutput; Utilities.unexpectedException --> Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem --> Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22317</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/ImagingParametersTest.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16983</td><td>2005-11-25</td><td>desruisseaux</td><td>Replaced references to static fields and methods of CitationImpl.* by Citations.*</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14725</td><td>2005-07-06</td><td>desruisseaux</td><td>Refactoring of GridCoverage operations: moved to a processing sub-package, operations are first-level classes (not inner classes), implementations hiden when possible, GridCoverageProcessor renamed as Processor and generalized (accepts Coverage instead of GridCoverage).</td></tr>
+<tr><td class="rev">14657</td><td>2005-07-01</td><td>desruisseaux</td><td>Ongoing work for the port of grid coverage operations from 'legacy' to 'main' (GEOT-413): ported SampleDimensionSelect</td></tr>
+<tr><td class="rev">14157</td><td>2005-06-07</td><td>desruisseaux</td><td>Added parameter wrappers around JAI's ParameterList, for implementation of GridCoverage operations backed by JAI operators</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/ParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/ParametersTest.xhtml (added)
+++ sis/ip-review/ParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParametersTest history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParametersTest history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ParametersTest.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29769</td><td>2008-04-02</td><td>desruisseaux</td><td>Renamed TestScript as ScriptRunner. Renamed XMatrix.epsilonEquals(...) as XMatrix.equals(...) in order to avoid ambiguity with GMatrix.epsilonEquals(...) at compile time.</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">29753</td><td>2008-04-01</td><td>desruisseaux</td><td>Applied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">28051</td><td>2007-11-26</td><td>desruisseaux</td><td>More Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should returns a set of Identifiers, not a set of Strings).</td></tr>
+<tr><td class="rev">27847</td><td>2007-11-12</td><td>desruisseaux</td><td>Replaced some references to 'org.geotools.util' by references to 'org.geotools.util.logging'. Removed the old classes to make sure that there is no more accidental references. Note that the old classes will not be removed from the 2.4 branch.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">26669</td><td>2007-08-22</td><td class="unav">gdavis</td><td><a href="rev/26669/ParametersTest.xhtml">fixing error related to new geoapi codelist changes, and adding geometry serialization test</a></td></tr>
+<tr><td class="rev">24576</td><td>2007-02-24</td><td>desruisseaux</td><td>Renamed 'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming. Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique' was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match more closely the common usage. In addition, also renamed some JUnit test classes in an attempt to make clearer what they are testing.</td></tr>
+<tr><td class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced the use of some deprecated methods (MonolineFormatter.initGeotools --> Logging.forceMonolineConsoleOutput; Utilities.unexpectedException --> Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem --> Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22317</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a href="rev/20874/ParametersTest.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15325</td><td>2005-08-13</td><td>desruisseaux</td><td>Created a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare branch for splitting main</td></tr>
+<tr><td class="rev">14581</td><td>2005-06-22</td><td>desruisseaux</td><td>Implemented South-Orientated transverse mercator / more GEOT-589 work</td></tr>
+<tr><td class="rev">14157</td><td>2005-06-07</td><td>desruisseaux</td><td>Added parameter wrappers around JAI's ParameterList, for implementation of GridCoverage operations backed by JAI operators</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">11137</td><td>2005-02-05</td><td>desruisseaux</td><td>Tune CRS tests (e.g. allow different tolerance level for assertions in different projections)</td></tr>
+<tr><td class="rev">11005</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/test</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ParametersTest.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">9132</td><td>2004-11-16</td><td>desruisseaux</td><td>Factored out WKT symbols in a Symbols class</td></tr>
+<tr><td class="rev">9118</td><td>2004-11-14</td><td>desruisseaux</td><td>Mercator projection port completed (but untested) as a use case for other projection ports</td></tr>
+<tr><td class="rev">8726</td><td>2004-10-21</td><td>desruisseaux</td><td>Various bug fixes in parameter handling</td></tr>
+<tr><td class="rev">8701</td><td>2004-10-20</td><td>desruisseaux</td><td>Added the 'remove' operation to ParameterValueGroup</td></tr>
+<tr><td class="rev">8674</td><td>2004-10-19</td><td>desruisseaux</td><td>Supports List.add(...) operation in the list returned by ParameterValueGroup.values()</td></tr>
+<tr><td class="rev">8621</td><td>2004-10-14</td><td>desruisseaux</td><td>Enforced 'maximumOccurs==1' in ParameterValue implementation</td></tr>
+<tr><td class="rev">8554</td><td>2004-10-12</td><td>desruisseaux</td><td>First draft of ParameterValueGroup.group(String) and addGroup(String) methods</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">7848</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a href="rev/07848/ParametersTest.xhtml">round 2 of sync with geoapi</a></td></tr>
+<tr><td class="rev">7710</td><td>2004-08-31</td><td class="unav">jgarnett</td><td><a href="rev/07848/ParametersTest.xhtml">Track changed to IdentifiedObject</a></td></tr>
+<tr><td class="rev">6589</td><td>2004-06-28</td><td>desruisseaux</td><td>Improved parameters handling</td></tr>
+<tr><td class="rev">6375</td><td>2004-06-10</td><td>desruisseaux</td><td>Work on parameters handling</td></tr>
+<tr><td class="rev">6371</td><td>2004-06-09</td><td>desruisseaux</td><td>Added test cases for parameters</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07848/ParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/ParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/07848/ParametersTest.xhtml (added)
+++ sis/ip-review/rev/07848/ParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,238 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParametersTest changes for revisions 7709:7848</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParametersTest changes for revisions 7709:7848</h1>
+<p>This commit contains only class name changes. Reverting this commit causes compilation errors, which can be fixed
+only by fixing the class names in this file. Note that Apache SIS class names are different than the ones in this commit,
+(e.g. <code>Parameter</code> → <code>DefaultParameterValue</code>), so the Apache SIS patch reproducing this
+commit is different.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7709:7848 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7709</th><th>Revision 7848</th></tr>
+<tr><td><pre> */
+public void testSequence() {
+    for (int i=-1000; i&lt;=1000; i++) {
+<span class="del">        assertEquals("Integer", i, new ParameterValue("Integer", i)          .intValue());</span>
+<span class="del">        assertEquals("Double",  i, new ParameterValue("Double",  i, null    ).doubleValue(), 0.0);</span>
+<span class="del">        assertEquals("Double",  i, new ParameterValue("Double",  i, Unit.ONE).doubleValue(), 0.0);</span>
+        assertEquals("Double",  Math.toRadians(i),
+<span class="del">                     new ParameterValue("Double",  i, NonSI.DEGREE_ANGLE).doubleValue(SI.RADIAN), 1E-6);</span>
+    }
+}</pre></td>
+<td><pre> */
+public void testSequence() {
+    for (int i=-1000; i&lt;=1000; i++) {
+<span class="add">        assertEquals("Integer", i, new Parameter("Integer", i)          .intValue());</span>
+<span class="add">        assertEquals("Double",  i, new Parameter("Double",  i, null    ).doubleValue(), 0.0);</span>
+<span class="add">        assertEquals("Double",  i, new Parameter("Double",  i, Unit.ONE).doubleValue(), 0.0);</span>
+        assertEquals("Double",  Math.toRadians(i),
+<span class="add">                     new Parameter("Double",  i, NonSI.DEGREE_ANGLE).doubleValue(SI.RADIAN), 1E-6);</span>
+    }
+}</pre></td></tr>
+<tr><td><pre> * inside and outside this range. Tests also the uses of values of the wrong type.
+ */
+public void testRangeIntegers() {
+<span class="del">    ParameterValue param;</span>
+<span class="del">    param = new ParameterValue(new OperationParameter("Range", 15, -30, +40));</span>
+    assertEquals("Range", 15, param.intValue());
+    assertEquals("Range", 15, param.doubleValue(), 0.0);
+    param.setValue(12);</pre></td>
+<td><pre> * inside and outside this range. Tests also the uses of values of the wrong type.
+ */
+public void testRangeIntegers() {
+<span class="add">    Parameter param;</span>
+<span class="add">    param = new Parameter(new ParameterDescriptor("Range", 15, -30, +40));</span>
+    assertEquals("Range", 15, param.intValue());
+    assertEquals("Range", 15, param.doubleValue(), 0.0);
+    param.setValue(12);</pre></td></tr>
+<tr><td><pre> * inside and outside this range. Tests also the uses of values of the wrong types.
+ */
+public void testRangeDoubles() {
+<span class="del">    ParameterValue param;</span>
+<span class="del">    param = new ParameterValue(new OperationParameter("Range", 15.0, -30.0, +40.0, null));</span>
+    assertEquals("Range", 15, param.intValue());
+    assertEquals("Range", 15, param.doubleValue(), 0.0);
+    param.setValue(12.0);</pre></td>
+<td><pre> * inside and outside this range. Tests also the uses of values of the wrong types.
+ */
+public void testRangeDoubles() {
+<span class="add">    Parameter param;</span>
+<span class="add">    param = new Parameter(new ParameterDescriptor("Range", 15.0, -30.0, +40.0, null));</span>
+    assertEquals("Range", 15, param.intValue());
+    assertEquals("Range", 15, param.doubleValue(), 0.0);
+    param.setValue(12.0);</pre></td></tr>
+<tr><td><pre> */
+public void testGroup() {
+    final Integer ONE = new Integer(1);
+<span class="del">    final OperationParameter p1, p2, p3;</span>
+<span class="del">    p1 = new OperationParameter(Collections.singletonMap("name", "1"), 1, 1, Integer.class, null, ONE, null, null, null);</span>
+<span class="del">    p2 = new OperationParameter(Collections.singletonMap("name", "2"), 1, 2, Integer.class, null, ONE, null, null, null);</span>
+<span class="del">    p3 = new OperationParameter(Collections.singletonMap("name", "3"), 0, 1, Integer.class, null, ONE, null, null, null);</span>
+<span class="del">    final ParameterValue v1, v2, v3, v1b, v2b, v3b, v1t, v2t, v3t;</span>
+<span class="del">    v1  = new ParameterValue(p1); v1.setValue( 10);</span>
+<span class="del">    v2  = new ParameterValue(p2); v2.setValue( 20);</span>
+<span class="del">    v3  = new ParameterValue(p3); v3.setValue( 30);</span>
+<span class="del">    v1b = new ParameterValue(p1); v1.setValue(-10);</span>
+<span class="del">    v2b = new ParameterValue(p2); v2.setValue(-20);</span>
+<span class="del">    v3b = new ParameterValue(p3); v3.setValue(-30);</span>
+    /*
+     * Test creation without pre-defined parameter group.
+     */
+    final Map properties = Collections.singletonMap("name", "group");
+<span class="del">    new ParameterValueGroup(properties, new ParameterValue[] {v1, v2, v3});</span>
+<span class="del">    new ParameterValueGroup(properties, new ParameterValue[] {v1, v2});</span>
+<span class="del">    new ParameterValueGroup(properties, new ParameterValue[] {v1, v3});</span>
+<span class="del">    new ParameterValueGroup(properties, new ParameterValue[] {v1, v2, v3, v2b});</span>
+    try {
+<span class="del">        new ParameterValueGroup(properties, new ParameterValue[] {v1, v2, v3, v3b});</span>
+        fail("Parameter 3 was not allowed to be inserted twice.");
+    } catch (IllegalArgumentException exception) {
+        // This is the expected exception.
+    }
+    try {
+<span class="del">        new ParameterValueGroup(properties, new ParameterValue[] {v1, v3, v1b});</span>
+        fail("Parameter 1 was not allowed to be inserted twice.");
+    } catch (IllegalArgumentException exception) {
+        // This is the expected exception.</pre></td>
+<td><pre> */
+public void testGroup() {
+    final Integer ONE = new Integer(1);
+<span class="add">    final ParameterDescriptor p1, p2, p3;</span>
+<span class="add">    p1 = new ParameterDescriptor(Collections.singletonMap("name", "1"), 1, 1, Integer.class, null, ONE, null, null, null);</span>
+<span class="add">    p2 = new ParameterDescriptor(Collections.singletonMap("name", "2"), 1, 2, Integer.class, null, ONE, null, null, null);</span>
+<span class="add">    p3 = new ParameterDescriptor(Collections.singletonMap("name", "3"), 0, 1, Integer.class, null, ONE, null, null, null);</span>
+<span class="add">    final Parameter v1, v2, v3, v1b, v2b, v3b, v1t, v2t, v3t;</span>
+<span class="add">    v1  = new Parameter(p1); v1.setValue( 10);</span>
+<span class="add">    v2  = new Parameter(p2); v2.setValue( 20);</span>
+<span class="add">    v3  = new Parameter(p3); v3.setValue( 30);</span>
+<span class="add">    v1b = new Parameter(p1); v1.setValue(-10);</span>
+<span class="add">    v2b = new Parameter(p2); v2.setValue(-20);</span>
+<span class="add">    v3b = new Parameter(p3); v3.setValue(-30);</span>
+    /*
+     * Test creation without pre-defined parameter group.
+     */
+    final Map properties = Collections.singletonMap("name", "group");
+<span class="add">    new ParameterGroup(properties, new Parameter[] {v1, v2, v3});</span>
+<span class="add">    new ParameterGroup(properties, new Parameter[] {v1, v2});</span>
+<span class="add">    new ParameterGroup(properties, new Parameter[] {v1, v3});</span>
+<span class="add">    new ParameterGroup(properties, new Parameter[] {v1, v2, v3, v2b});</span>
+    try {
+<span class="add">        new ParameterGroup(properties, new Parameter[] {v1, v2, v3, v3b});</span>
+        fail("Parameter 3 was not allowed to be inserted twice.");
+    } catch (IllegalArgumentException exception) {
+        // This is the expected exception.
+    }
+    try {
+<span class="add">        new ParameterGroup(properties, new Parameter[] {v1, v3, v1b});</span>
+        fail("Parameter 1 was not allowed to be inserted twice.");
+    } catch (IllegalArgumentException exception) {
+        // This is the expected exception.</pre></td></tr>
+<tr><td><pre>/*
+ * Test creation with a pre-defined parameter group.
+ */
+<span class="del">final OperationParameterGroup group =</span>
+<span class="del">      new OperationParameterGroup(properties, new OperationParameter[] {p1, p2, p3});</span>
+<span class="del">new ParameterValueGroup(group, new ParameterValue[] {v1, v2, v3});</span>
+<span class="del">new ParameterValueGroup(group, new ParameterValue[] {v1, v2});</span>
+<span class="del">new ParameterValueGroup(group, new ParameterValue[] {v1, v2, v3, v2b});</span>
+try {
+<span class="del">    new ParameterValueGroup(group, new ParameterValue[] {v1, v3});</span>
+    fail("Parameter 2 was mandatory.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.
+}
+try {
+<span class="del">    new ParameterValueGroup(group, new ParameterValue[] {v1, v2, v3, v3b});</span>
+    fail("Parameter 3 was not allowed to be inserted twice.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.
+}
+try {
+<span class="del">    new ParameterValueGroup(group, new ParameterValue[] {v1, v3, v1b});</span>
+    fail("Parameter 1 was not allowed to be inserted twice.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.</pre></td>
+<td><pre>/*
+ * Test creation with a pre-defined parameter group.
+ */
+<span class="add">final ParameterGroupDescriptor group =</span>
+<span class="add">      new ParameterGroupDescriptor(properties, new ParameterDescriptor[] {p1, p2, p3});</span>
+<span class="add">new ParameterGroup(group, new Parameter[] {v1, v2, v3});</span>
+<span class="add">new ParameterGroup(group, new Parameter[] {v1, v2});</span>
+<span class="add">new ParameterGroup(group, new Parameter[] {v1, v2, v3, v2b});</span>
+try {
+<span class="add">    new ParameterGroup(group, new Parameter[] {v1, v3});</span>
+    fail("Parameter 2 was mandatory.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.
+}
+try {
+<span class="add">    new ParameterGroup(group, new Parameter[] {v1, v2, v3, v3b});</span>
+    fail("Parameter 3 was not allowed to be inserted twice.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.
+}
+try {
+<span class="add">    new ParameterGroup(group, new Parameter[] {v1, v3, v1b});</span>
+    fail("Parameter 1 was not allowed to be inserted twice.");
+} catch (IllegalArgumentException exception) {
+    // This is the expected exception.</pre></td></tr>
+<tr><td><pre> * parameter.
+ */
+public void testCodeList() {
+<span class="del">    ParameterValue param = new ParameterValue("Test", AxisDirection.TOP);</span>
+<span class="del">    OperationParameter op = (OperationParameter) param.getDescriptor();</span>
+    assertEquals("CodeList", new HashSet(Arrays.asList(AxisDirection.values())), op.getValidValues());
+    assertEquals("Default", AxisDirection.TOP, op.getDefaultValue());
+    param.setValue(AxisDirection.DOWN);</pre></td>
+<td><pre> * parameter.
+ */
+public void testCodeList() {
+<span class="add">    Parameter param = new Parameter("Test", AxisDirection.TOP);</span>
+<span class="add">    ParameterDescriptor op = (ParameterDescriptor) param.getDescriptor();</span>
+    assertEquals("CodeList", new HashSet(Arrays.asList(AxisDirection.values())), op.getValidValues());
+    assertEquals("Default", AxisDirection.TOP, op.getDefaultValue());
+    param.setValue(AxisDirection.DOWN);</pre></td></tr>
+<tr><td><pre>    } catch (InvalidParameterValueException exception) {
+        // This is the expected exception.
+    }
+<span class="del">    param = new ParameterValue("Test", AxisDirection.TOP);</span>
+    param.setValue(dummy); // Should not fails.
+    assertEquals("Equals", param, param.clone());
+}</pre></td>
+<td><pre>    } catch (InvalidParameterValueException exception) {
+        // This is the expected exception.
+    }
+<span class="add">    param = new Parameter("Test", AxisDirection.TOP);</span>
+    param.setValue(dummy); // Should not fails.
+    assertEquals("Equals", param, param.clone());
+}</pre></td></tr>
+<tr><td><pre>    GeneralMatrix copy = (GeneralMatrix) matrix.clone();
+    copy.setSize(height, width);
+    parameters.setMatrix(copy);
+<span class="del">    assertEquals("height", height, ((ParameterValue) parameters.getValue("num_row")).intValue());</span>
+<span class="del">    assertEquals("width",  width,  ((ParameterValue) parameters.getValue("num_col")).intValue());</span>
+    assertEquals("equals", copy,   parameters.getMatrix());
+    assertEquals("Equals", parameters, parameters.clone());
+}</pre></td>
+<td><pre>    GeneralMatrix copy = (GeneralMatrix) matrix.clone();
+    copy.setSize(height, width);
+    parameters.setMatrix(copy);
+<span class="add">    assertEquals("height", height, ((Parameter) parameters.getValue("num_row")).intValue());</span>
+<span class="add">    assertEquals("width",  width,  ((Parameter) parameters.getValue("num_col")).intValue());</span>
+    assertEquals("equals", copy,   parameters.getMatrix());
+    assertEquals("Equals", parameters, parameters.clone());
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07848/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07848/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/ParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ParametersTest.xhtml (added)
+++ sis/ip-review/rev/10796/ParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,116 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParametersTest changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParametersTest changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>" tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2004, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2004, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.referencing;
+
+// J2SE dependencies and extensions
+<span class="del">import java.io.*;</span>
+<span class="del">import java.util.*;</span>
+<span class="del">import javax.units.Unit;</span>
+<span class="del">import javax.units.SI;</span>
+<span class="del">import javax.units.NonSI;</span>
+<span class="del">import junit.framework.*;</span>
+import java.awt.geom.AffineTransform;
+
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.datum.VerticalDatumType;
+import org.opengis.referencing.operation.MathTransform;
+<span class="del">import org.opengis.parameter.ParameterNotFoundException;</span>
+<span class="del">import org.opengis.parameter.InvalidParameterNameException;</span>
+<span class="del">import org.opengis.parameter.InvalidParameterTypeException;</span>
+<span class="del">import org.opengis.parameter.InvalidParameterValueException;</span>
+<span class="del">import org.opengis.parameter.InvalidParameterCardinalityException;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.parameter.*;</span>
+<span class="del">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="del">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="del">import org.geotools.referencing.operation.transform.ProjectiveTransform;</span>
+
+<span class="del"></span>
+/**
+ * Tests the &lt;code&gt;org.geotools.parameter&lt;/code&gt; package.
+ *</pre></td>
+<td><pre>package org.geotools.referencing;
+
+// J2SE dependencies and extensions
+import java.awt.geom.AffineTransform;
+<span class="add">import java.io.ByteArrayInputStream;</span>
+<span class="add">import java.io.ByteArrayOutputStream;</span>
+<span class="add">import java.io.IOException;</span>
+<span class="add">import java.io.ObjectInputStream;</span>
+<span class="add">import java.io.ObjectOutputStream;</span>
+<span class="add">import java.util.Arrays;</span>
+<span class="add">import java.util.Collection;</span>
+<span class="add">import java.util.Collections;</span>
+<span class="add">import java.util.HashSet;</span>
+<span class="add">import java.util.Map;</span>
+<span class="add">import java.util.Random;</span>
+<span class="add">import java.util.Set;</span>
+
+<span class="add">import javax.units.NonSI;</span>
+<span class="add">import javax.units.SI;</span>
+<span class="add">import javax.units.Unit;</span>
+<span class="add"></span>
+<span class="add">import junit.framework.Test;</span>
+<span class="add">import junit.framework.TestCase;</span>
+<span class="add">import junit.framework.TestSuite;</span>
+<span class="add"></span>
+<span class="add">import org.geotools.parameter.MatrixParameterDescriptors;</span>
+<span class="add">import org.geotools.parameter.MatrixParameterValues;</span>
+<span class="add">import org.geotools.parameter.Parameter;</span>
+<span class="add">import org.geotools.parameter.ParameterDescriptor;</span>
+<span class="add">import org.geotools.parameter.ParameterDescriptorGroup;</span>
+<span class="add">import org.geotools.parameter.ParameterGroup;</span>
+<span class="add">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="add">import org.geotools.referencing.operation.transform.ProjectiveTransform;</span>
+<span class="add">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="add">import org.opengis.parameter.InvalidParameterCardinalityException;</span>
+<span class="add">import org.opengis.parameter.InvalidParameterNameException;</span>
+<span class="add">import org.opengis.parameter.InvalidParameterTypeException;</span>
+<span class="add">import org.opengis.parameter.InvalidParameterValueException;</span>
+<span class="add">import org.opengis.parameter.ParameterNotFoundException;</span>
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.datum.VerticalDatumType;
+import org.opengis.referencing.operation.MathTransform;
+
+
+/**
+ * Tests the &lt;code&gt;org.geotools.parameter&lt;/code&gt; package.
+ *</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/ImagingParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/ImagingParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/20874/ImagingParametersTest.xhtml (added)
+++ sis/ip-review/rev/20874/ImagingParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ImagingParametersTest changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ImagingParametersTest changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ImagingParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2005, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2005-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.parameter;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.parameter;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/ParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/ParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/20874/ParametersTest.xhtml (added)
+++ sis/ip-review/rev/20874/ParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParametersTest changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParametersTest changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option) any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2004, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.parameter;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.parameter;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24868/ImagingParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24868/ImagingParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/24868/ImagingParametersTest.xhtml (added)
+++ sis/ip-review/rev/24868/ImagingParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,35 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ImagingParametersTest changes for revisions 24867:24868</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ImagingParametersTest changes for revisions 24867:24868</h1>
+<p>This commit has been reverted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24867:24868 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ImagingParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24867</th><th>Revision 24868</th></tr>
+<tr><td><pre>assertEquals   ("Name",  "AddConst", parameters.getName().getCode());
+assertEquals   ("Authority", author, parameters.getName().getAuthority().getTitle().toString());
+assertEquals   ("Vendor",    vendor, alias     .getScope().toString());
+<span class="del">assertNotNull  ("Version",           parameters.getName().getVersion());</span>
+assertLocalized("Vendor",            alias     .getScope().toInternationalString());
+assertLocalized("Remarks",           parameters.getRemarks());
+assertTrue     ("Remarks",           parameters.getRemarks().toString().trim().length() &gt; 0);</pre></td>
+<td><pre>assertEquals   ("Name",  "AddConst", parameters.getName().getCode());
+assertEquals   ("Authority", author, parameters.getName().getAuthority().getTitle().toString());
+assertEquals   ("Vendor",    vendor, alias     .getScope().toString());
+<span class="add">//assertNotNull  ("Version",           parameters.getName().getVersion());</span>
+assertLocalized("Vendor",            alias     .getScope().toInternationalString());
+assertLocalized("Remarks",           parameters.getRemarks());
+assertTrue     ("Remarks",           parameters.getRemarks().toString().trim().length() &gt; 0);</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24868/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24868/ImagingParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/26669/ParametersTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/26669/ParametersTest.xhtml?rev=1565708&view=auto
==============================================================================
--- sis/ip-review/rev/26669/ParametersTest.xhtml (added)
+++ sis/ip-review/rev/26669/ParametersTest.xhtml Fri Feb  7 16:07:19 2014
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ParametersTest changes for revisions 26668:26669</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ParametersTest changes for revisions 26668:26669</h1>
+<p>Change forced by a change in GeoAPI: code list constructors are no longer public.
+Reverting this commit causes a compilation error which can be fixed only by re-applying the exact same patch.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r26668:26669 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/parameter/ParametersTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 26668</th><th>Revision 26669</th></tr>
+<tr><td><pre>    // This is the expected exception.
+    assertEquals("Test", exception.getParameterName());
+}
+<span class="del">AxisDirection dummy = new AxisDirection("Dummy");</span>
+try {
+    param.setValue(dummy);
+    fail("setValue(AxisDirection)");</pre></td>
+<td><pre>    // This is the expected exception.
+    assertEquals("Test", exception.getParameterName());
+}
+<span class="add">AxisDirection dummy = AxisDirection.valueOf("Dummy");</span>
+try {
+    param.setValue(dummy);
+    fail("setValue(AxisDirection)");</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/26669/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/26669/ParametersTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message