singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] moazreyad commented on issue #796: codecov/project fail
Date Thu, 17 Sep 2020 09:43:25 GMT

moazreyad commented on issue #796:
URL: https://github.com/apache/singa/issues/796#issuecomment-694121140


   > After fixing the python version issue, code coverage fails again..
   
   The coverage is now decreased by 0.01% instead of 4.97%. It still fails because we did
not specify a threshold, so any decrease any in the coverage will make test fails. To solve
this problem, either add a small threshold like 0.1 % to allow small drops in coverage generally
in all PRs, or leave the threshold decision to each pull request reviewer to decide if the
decrease in the specific PR is fine and it can be merged or it is not fine and must be fixed.
   
   > Seems it does not provide the suggestions on how to improve the code coverage.
   
   Yes, it just reports the coverage results without suggestions on how to fix. This is similar
to all the test cases which report the error but of course they do not usually suggest how
to fix it. 
   
   To improve the coverage, the developer needs to investigate more how to create the suitable
test cases to cover his new code, or how not to prevent current test cases from running (like
the problem that we had in #795). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message